-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: SqlAg & SqlReplica: Removes SQLServerNetName in favor of EndpointHostName #938
Conversation
- The read-only property SQLServerNetName was removed in favor of EndpointHostName (issue dsccommunity#924). Get-TargetResource will return the value of property NetName as the default value if EndpointHostName parameter is not assigned a value.
- The read-only property SQLServerNetName was removed in favor of EndpointHostName (issue dsccommunity#924). Get-TargetResource will return the value of property NetName as the default value if EndpointHostName parameter is not assigned a value.
Codecov Report
@@ Coverage Diff @@
## dev #938 +/- ##
===================================
Coverage 96% 96%
===================================
Files 32 32
Lines 3515 3515
===================================
Hits 3395 3395
Misses 120 120 |
Reviewed 6 of 7 files at r1, 1 of 1 files at r2. CHANGELOG.md, line 27 at r2 (raw file):
This is wrong, it will always return the NetName as the value. CHANGELOG.md, line 47 at r2 (raw file):
This is wrong, it will always return the NetName as the value. Comments from Reviewable |
Review status: 6 of 7 files reviewed at latest revision, 2 unresolved discussions. CHANGELOG.md, line 27 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. CHANGELOG.md, line 47 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
Pull Request (PR) description
as the default value if EndpointHostName parameter is not assigned a value.
as the default value if EndpointHostName parameter is not assigned a value.
This Pull Request (PR) fixes the following issues:
Fixes #924
Task list:
This change is