-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlAG & SqlAGReplica: Remove parameter SQLServerNetName #924
Comments
@randomnote1 @nabrond next one, what do you think? |
I'm open for other names. Maybe |
NetName is the property off of the server object that is used. This is either the node name or the virtual computer object name of the FCI. |
|
Should we drop the parameter all together? It looks like it is only used in the |
I agree, I think doing the below would result in the same thing, and we could remove the parameter. I'm thinking of the above change, since the So, changing this row in Into $alwaysOnAvailabilityGroupResource.EndpointHostName = $serverObject.NetName and changing this code block in into if ( -not $EndpointHostName )
{
$EndpointHostName = $getTargetResourceResult.EndpointHostName
} |
In the Get-TargetResource function we could also return the value of the |
Well, I'm not entirely sure why I chose to create a read-only property for |
@randomnote1 The same logic seem to exist in SqlAgReplica as well. So changing that as well. Working on this now. |
- The read-only property SQLServerNetName was removed in favor of EndpointHostName (issue dsccommunity#924). Get-TargetResource will return the value of property NetName as the default value if EndpointHostName parameter is not assigned a value.
- The read-only property SQLServerNetName was removed in favor of EndpointHostName (issue dsccommunity#924). Get-TargetResource will return the value of property NetName as the default value if EndpointHostName parameter is not assigned a value.
That makes sense. Thanks! |
…Name (#938) - Changes to SqlAG - BREAKING CHANGE: The read-only property SQLServerNetName was removed in favour of EndpointHostName (issue #924). Get-TargetResource will now return the value of property NetName for the property EndpointHostName. - Changes to SqlAGReplica - BREAKING CHANGE: The read-only property SQLServerNetName was removed in favour of EndpointHostName (issue #924). Get-TargetResource will now return the value of property NetName for the property EndpointHostName.
Details of the scenario you tried and the problem that is occurring:
The work renaming parameters in issue #308 does not mention the parameter
SQLServerNetName
in the resource SqlAG.https://github.com/PowerShell/SqlServerDsc/blob/9a1080c4da5d513eb4191388206cf37c16c0a0fd/DSCResources/MSFT_SqlAG/MSFT_SqlAG.schema.mof#L23
I suggest we rename it to
NetName
.The DSC configuration that is using the resource (as detailed as possible):
n/a
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a
What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
The text was updated successfully, but these errors were encountered: