-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlAG: unit tests converted to Pester 5 #1987
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1987 +/- ##
=====================================
+ Coverage 92% 94% +2%
=====================================
Files 93 93
Lines 7840 7844 +4
=====================================
+ Hits 7214 7424 +210
+ Misses 626 420 -206
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, than you for this! Just a tiny comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Sidoran)
source/DSCResources/DSC_SqlAG/DSC_SqlAG.psm1
line 755 at r1 (raw file):
<# Add properties compatible with SQL Server 2016 or later versions DtcSupportEnabled is enabled at the creation of the Availability Group only, hence it will not be checked in this block
We should remove this comment from the code as well.
Code quote:
DtcSupportEnabled is enabled at the creation of the Availability Group only, hence it will not be checked in this block
@johlju, Looks like starting from the SQL 2016 SP2, we can change the DtcSupportEnabled option for the existing Availability group proof |
I haven't tested using code coverage in VS Code. I always run the code coverage in command line using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Sidoran)
Pull Request (PR) description
Convert SqlAG unit tests to Pester 5 plus add missed parameters to a SQLAG Test and Get functions.
Fix unit test for the SQLAGReplica
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is