SqlAG: unit tests converted to Pester 5 (#1987)

- SqlAGReplica - Fix unit test FailedRemoveAvailabilityGroupReplica - SqlAG - Converted unit test to Pester 5 - DtcSupportEnabled option in Set-TargetResource and TestTargetResource
dsccommunity · Dec 15, 2023 · a9f8f26 · a9f8f26
1 parent 22b25f6
commit a9f8f26
Show file tree

Hide file tree

Showing 4 changed files with 1,360 additions and 1,192 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,9 +14,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     - Fix sort to get the latest version
 - `Assert-Feature`
   - Fixed unit tests.
+- SqlAGReplica
+  - Fix unit test FailedRemoveAvailabilityGroupReplica
 
 ### Changed
 
+- SqlAG
+  - Converted unit test to Pester 5
+  - DtcSupportEnabled option in Set-TargetResource and TestTargetResource
 - SqlServerDsc
   - Bump PSResourceGet to v1.0.0 (used when resolving dependencies).
   - Update markdown highlights with newly supported keywords.

diff --git a/source/DSCResources/DSC_SqlAG/DSC_SqlAG.psm1 b/source/DSCResources/DSC_SqlAG/DSC_SqlAG.psm1
@@ -464,6 +464,12 @@ function Set-TargetResource
                     Update-AvailabilityGroup -AvailabilityGroup $availabilityGroup
                 }
 
+                if ( ( $submittedParameters -contains 'DtcSupportEnabled' ) -and ( $sqlMajorVersion -ge 13 ) -and ( $DtcSupportEnabled -ne $availabilityGroup.DtcSupportEnabled ) )
+                {
+                    $availabilityGroup.DtcSupportEnabled = $DtcSupportEnabled
+                    Update-AvailabilityGroup -AvailabilityGroup $availabilityGroup
+                }
+
                 # Make sure ConnectionModeInPrimaryRole has a value in order to avoid false positive matches when the parameter is not defined
                 if ( ( $submittedParameters -contains 'ConnectionModeInPrimaryRole' ) -and ( -not [System.String]::IsNullOrEmpty($ConnectionModeInPrimaryRole) ) -and ( $ConnectionModeInPrimaryRole -ne $availabilityGroup.AvailabilityReplicas[$serverObject.DomainInstanceName].ConnectionModeInPrimaryRole ) )
                 {
@@ -746,13 +752,13 @@ function Test-TargetResource
 
             <#
                 Add properties compatible with SQL Server 2016 or later versions
-                DtcSupportEnabled is enabled at the creation of the Availability Group only, hence it will not be checked in this block
                 SeedingMode should be checked only in case if New-SqlAvailabilityReplica support the SeedingMode parameter
             #>
             if ( $sqlMajorVersion -ge 13 )
             {
                 $parametersToCheck += 'BasicAvailabilityGroup'
                 $parametersToCheck += 'DatabaseHealthTrigger'
+                $parametersToCheck += 'DtcSupportEnabled'
                 if ( $getTargetResourceResult.SeedingMode )
                 {
                     $parametersToCheck += 'SeedingMode'