Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Integration tests for SQL Server Reporting Services 2022 #1804

Merged
merged 6 commits into from
Nov 27, 2022

Conversation

johlju
Copy link
Member

@johlju johlju commented Nov 26, 2022

Pull Request (PR) description

  • SqlServerDsc
    • Integration tests are now also run on SQL Server Reporting Services 2022.

This PR is dependent on PR #1803.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Nov 26, 2022
@johlju johlju force-pushed the f/integration-tests-on-RS2022 branch from ca17f37 to c1a5161 Compare November 26, 2022 09:58
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #1804 (3d81895) into main (a512eff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1804   +/-   ##
====================================
  Coverage    88%     88%           
====================================
  Files        83      83           
  Lines      7444    7444           
====================================
  Hits       6594    6594           
  Misses      850     850           
Flag Coverage Δ
unit 88% <ø> (ø)

@johlju johlju force-pushed the f/integration-tests-on-RS2022 branch from c1a5161 to a1bf952 Compare November 26, 2022 13:03
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Nov 26, 2022
@johlju johlju force-pushed the f/integration-tests-on-RS2022 branch from a1bf952 to cf06a48 Compare November 26, 2022 16:28
@johlju johlju force-pushed the f/integration-tests-on-RS2022 branch from cf06a48 to 3d81895 Compare November 26, 2022 18:15
@johlju
Copy link
Member Author

johlju commented Nov 26, 2022

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@johlju johlju merged commit 8dde54d into dsccommunity:main Nov 27, 2022
@johlju johlju deleted the f/integration-tests-on-RS2022 branch November 27, 2022 10:30
@johlju johlju removed the needs review The pull request needs a code review. label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant