Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Integration tests for SQL Server 2022 #1803

Merged
merged 14 commits into from
Nov 26, 2022

Conversation

johlju
Copy link
Member

@johlju johlju commented Nov 26, 2022

Pull Request (PR) description

  • SqlServerDsc
    • Integration tests are now also run on SQL Server 2022.
  • SqlDatabase
    • Added compatibility levels for SQL Server 2022 (major version 16).
  • SqlSetup
    • Paths for SQL Server 2022 are correctly returned by Get.

This Pull Request (PR) fixes the following issues

None. But added a few new issues.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Nov 26, 2022
@johlju johlju force-pushed the f/integration-tests-on-SQL2022 branch from eabcab3 to b924976 Compare November 26, 2022 09:56
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #1803 (b924976) into main (1026d20) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1803   +/-   ##
====================================
  Coverage    88%     88%           
====================================
  Files        83      83           
  Lines      7443    7444    +1     
====================================
+ Hits       6593    6594    +1     
  Misses      850     850           
Flag Coverage Δ
unit 88% <100%> (+<1%) ⬆️
Impacted Files Coverage Δ
.../DSCResources/DSC_SqlDatabase/DSC_SqlDatabase.psm1 97% <100%> (+<1%) ⬆️
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 98% <100%> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)


tests/Integration/DSC_SqlAgentAlert.Integration.Tests.ps1 line 39 at r1 (raw file):

}

Describe "<dscResourceFriendlyName>_Integration" -Tag @('Integration_SQL2016', 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022', 'Integration_SQL2022') {

Duplicaye tag. Will fix in next PR.

Code quote:

'Integration_SQL2022'

@johlju johlju merged commit a512eff into dsccommunity:main Nov 26, 2022
@johlju johlju deleted the f/integration-tests-on-SQL2022 branch November 26, 2022 12:57
@johlju johlju removed the needs review The pull request needs a code review. label Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant