-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerDsc: Integration tests for SQL Server 2022 #1803
SqlServerDsc: Integration tests for SQL Server 2022 #1803
Conversation
eabcab3
to
b924976
Compare
Codecov Report
@@ Coverage Diff @@
## main #1803 +/- ##
====================================
Coverage 88% 88%
====================================
Files 83 83
Lines 7443 7444 +1
====================================
+ Hits 6593 6594 +1
Misses 850 850
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
tests/Integration/DSC_SqlAgentAlert.Integration.Tests.ps1
line 39 at r1 (raw file):
} Describe "<dscResourceFriendlyName>_Integration" -Tag @('Integration_SQL2016', 'Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022', 'Integration_SQL2022') {
Duplicaye tag. Will fix in next PR.
Code quote:
'Integration_SQL2022'
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
None. But added a few new issues.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is