Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlDatabaseRole: Add a test to check error message on helper function #1626

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

jpomfret
Copy link
Contributor

@jpomfret jpomfret commented Oct 18, 2020

Pull Request (PR) description

Adds a test to ensure Add-SqlDscDatabaseRoleMember throws the expected error.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@jpomfret jpomfret force-pushed the issue_1620_SqlDatabaseRole branch from 0d6e811 to 6a8365d Compare October 18, 2020 10:53
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #1626 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1626   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          37      37           
  Lines        6014    6014           
======================================
  Hits         5925    5925           
  Misses         89      89           
Flag Coverage Δ
#unit 98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@johlju johlju added the needs review The pull request needs a code review. label Oct 28, 2020
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju removed the needs review The pull request needs a code review. label Oct 29, 2020
@johlju
Copy link
Member

johlju commented Oct 29, 2020

Sorry it took so long for me to review this. Work is extreme at the moment. 🙂

@johlju johlju merged commit 56ebcfe into dsccommunity:master Oct 29, 2020
@johlju johlju changed the title DSC_SqlDatabaseRole: Add a test to check error message on helper function SqlDatabaseRole: Add a test to check error message on helper function Oct 29, 2020
@jpomfret
Copy link
Contributor Author

No problem at all. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlDatabaseRole: Missing unit test for helper function Add-SqlDscDatabaseRoleMember
2 participants