Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlDatabaseRole: Missing unit test for helper function Add-SqlDscDatabaseRoleMember #1620

Closed
johlju opened this issue Oct 2, 2020 · 0 comments · Fixed by #1626
Closed

SqlDatabaseRole: Missing unit test for helper function Add-SqlDscDatabaseRoleMember #1620

johlju opened this issue Oct 2, 2020 · 0 comments · Fixed by #1626
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Oct 2, 2020

We should add a unit test for the helper function Add-SqlDscDatabaseRoleMember in the DSC resource SqlDatabaseRole that for example properly tests the error that could be thrown.
@johlju johlju added good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Oct 2, 2020
jpomfret pushed a commit to jpomfret/SqlServerDsc that referenced this issue Oct 18, 2020
add a test to resolve issue dsccommunity#1620
0d6e811
@jpomfret jpomfret mentioned this issue Oct 18, 2020
Merged
9 tasks
jpomfret pushed a commit to jpomfret/SqlServerDsc that referenced this issue Oct 18, 2020
@jpomfret
add a test to resolve issue dsccommunity#1620
6a8365d
johlju pushed a commit that referenced this issue Oct 29, 2020
@jpomfret
SqlDatabaseRole: Add a test to check error message on helper function (…
56ebcfe 
…#1626)

- SqlDatabaseRole
  - Added test to ensure Add-SqlDscDatabaseRoleMember throws the expected error (issue #1620).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlDatabaseRole: Add a test to check error message on helper function jpomfret/SqlServerDsc
1 participant
@johlju