SqlSetup,SqlWindowsFirewall: Fix duplicate function

[johlju]

Pull Request (PR) description

• SqlServerDsc
  • Document changes in the file build.yml.
• SqlSetup
  • Duplicate function Get-SqlMajorVersion was removed and instead the
    helper function Get-FilePathMajorVersion from the helper module
    SqlServerDsc.Common is used (issue SqlSetup and SqlWindowsFirewall: Duplicate helper function Get-SqlMajorVersion #1178).
• SqlWindowsFirewall
  • Duplicate function Get-SqlMajorVersion was removed and instead the
    helper function Get-FilePathMajorVersio` from the helper module
    SqlServerDsc.Common is used (issue SqlSetup and SqlWindowsFirewall: Duplicate helper function Get-SqlMajorVersion #1178).
• SqlServerDsc.Common
  • Function Get-FilePathMajorVersion was added. The function Get-SqlMajorVersion
    from the resources SqlSetup and SqlWindowsFirewall was moved and
    renamed without any functional changes (issue SqlSetup and SqlWindowsFirewall: Duplicate helper function Get-SqlMajorVersion #1178).

This Pull Request (PR) fixes the following issues

• Fixes SqlSetup and SqlWindowsFirewall: Duplicate helper function Get-SqlMajorVersion #1178

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1608 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1608   +/-   ##
======================================
  Coverage      98%     98%           
======================================
  Files          37      37           
  Lines        5964    5963    -1     
======================================
  Hits         5874    5874           
+ Misses         90      89    -1     

Flag	Coverage Δ
#unit	98% <100%> (+<1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1	98% <100%> (+<1%)	⬆️
...DSC_SqlWindowsFirewall/DSC_SqlWindowsFirewall.psm1	100% <100%> (ø)
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1	97% <100%> (+<1%)	⬆️

[johlju]

I will merge this as I testing a problem with Codecov.io when merging to a branch.

[johlju]

Reviewed 9 of 9 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved