SqlSetup and SqlWindowsFirewall: Duplicate helper function Get-SqlMajorVersion #1178
Labels
enhancement
The issue is an enhancement request.
good first issue
The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Details of the scenario you tried and the problem that is occurring
The helper function is duplicated between the resources SqlSetup and SqlWindowsFirewall. This should be moved to the helper module instead, to be a common helper function.
Maybe the function should be renamed to
Get-SqlPathMajorVersion
or similar.https://github.com/PowerShell/SqlServerDsc/blob/6328f40f7121131f72ee62fdf6470f5ed569953e/DSCResources/MSFT_SqlWindowsFirewall/MSFT_SqlWindowsFirewall.psm1#L793-L804
The DSC configuration that is using the resource (as detailed as possible)
n/a
Version of the operating system and PowerShell the target node is running
n/a
SQL Server edition and version the target node is running
n/a
What SQL Server PowerShell modules, and which version, are present on the target node.
n /a
Version of the DSC module you're using, or write 'dev' if you're using current dev branch
Dev
The text was updated successfully, but these errors were encountered: