-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: SqlServerDsc: Support Pester 5 #1550
Conversation
9aff055
to
94b028f
Compare
62bbfff
to
d3dd338
Compare
I have rebase and update new unit tests to pass Pester 5. Also fixed error handling using localized strings using |
To convert all tests will be a massive undertaking since some tests that pass in Pester 5 does not pass in Pester 4.10.1. This is due to Pester 5 actually does everything better and more correctly. 🙂 |
7bd3c7b
to
a7d8e44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion
debug.ps1, line 1 at r3 (raw file):
# This file should be removed before the pull request is reviewed
Leave a note her so that we remember to remove this file once the pipeline is updated.
5061fbc
to
9a5ae6a
Compare
9a5ae6a
to
4ccb37b
Compare
4ccb37b
to
f46efa3
Compare
f46efa3
to
4fa086a
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Now the HQRM tests have been converted to Pester 5 - so once all unit test have been converted this can merge! |
7f7d166
to
11777ce
Compare
11777ce
to
4217060
Compare
e541cf7
to
86b2c23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 47 of 87 files at r4, 14 of 23 files at r5, 1 of 3 files at r6, 36 of 36 files at r8.
Reviewable status: all files reviewed, 1 unresolved discussion
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Fixes #747
Closes #1654
Fixes #979
Closes #1634
Fixes #1721
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is