Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: SqlServerDsc: Support Pester 5 #1550

Merged
merged 179 commits into from
Jun 6, 2022

Conversation

johlju
Copy link
Member

@johlju johlju commented May 16, 2020

Pull Request (PR) description

  • Initial support for Pester 5 to determine the amount of work needed to convert all tests.

This Pull Request (PR) fixes the following issues

Fixes #747
Closes #1654
Fixes #979
Closes #1634
Fixes #1721

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. on hold The issue or pull request has been put on hold by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 16, 2020
@johlju johlju force-pushed the f/support-pester-5 branch from 9aff055 to 94b028f Compare October 16, 2020 09:11
@johlju johlju mentioned this pull request Nov 30, 2020
9 tasks
@johlju johlju force-pushed the f/support-pester-5 branch from 62bbfff to d3dd338 Compare December 16, 2020 10:33
@johlju
Copy link
Member Author

johlju commented Dec 16, 2020

I have rebase and update new unit tests to pass Pester 5. Also fixed error handling using localized strings using InModuleScope. The unit tests for SqlServerDsc.Common now passes locally again.

@johlju johlju changed the title SqlServerDsc.Common: Support Pester 5 SqlServerDsc: Support Pester 5 Dec 16, 2020
@johlju
Copy link
Member Author

johlju commented Dec 16, 2020

To convert all tests will be a massive undertaking since some tests that pass in Pester 5 does not pass in Pester 4.10.1. This is due to Pester 5 actually does everything better and more correctly. 🙂

@johlju johlju mentioned this pull request Dec 22, 2020
62 tasks
@johlju johlju force-pushed the f/support-pester-5 branch 7 times, most recently from 7bd3c7b to a7d8e44 Compare December 27, 2020 12:19
@Fiander Fiander mentioned this pull request Dec 27, 2020
9 tasks
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion


debug.ps1, line 1 at r3 (raw file):

# This file should be removed before the pull request is reviewed

Leave a note her so that we remember to remove this file once the pipeline is updated.

@johlju johlju force-pushed the f/support-pester-5 branch 2 times, most recently from 5061fbc to 9a5ae6a Compare January 6, 2021 07:20
@johlju johlju changed the base branch from master to main January 8, 2021 15:46
@johlju johlju force-pushed the f/support-pester-5 branch from 9a5ae6a to 4ccb37b Compare January 12, 2021 11:04
@johlju johlju force-pushed the f/support-pester-5 branch from 4ccb37b to f46efa3 Compare January 27, 2021 17:44
@johlju johlju force-pushed the f/support-pester-5 branch from f46efa3 to 4fa086a Compare February 6, 2021 06:06
@johlju
Copy link
Member Author

johlju commented Feb 9, 2021

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@johlju
Copy link
Member Author

johlju commented Feb 9, 2021

Now the HQRM tests have been converted to Pester 5 - so once all unit test have been converted this can merge!

@johlju johlju force-pushed the f/support-pester-5 branch from 7f7d166 to 11777ce Compare February 12, 2021 10:20
@johlju johlju force-pushed the f/support-pester-5 branch from 11777ce to 4217060 Compare March 11, 2021 15:08
@johlju johlju force-pushed the f/support-pester-5 branch from e541cf7 to 86b2c23 Compare June 6, 2022 08:12
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 47 of 87 files at r4, 14 of 23 files at r5, 1 of 3 files at r6, 36 of 36 files at r8.
Reviewable status: all files reviewed, 1 unresolved discussion

@johlju johlju merged commit d6eebb5 into dsccommunity:main Jun 6, 2022
@johlju johlju deleted the f/support-pester-5 branch June 6, 2022 11:39
@johlju johlju removed the needs review The pull request needs a code review. label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment