Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlLogin: Integration tests fails intermittently #1634

Closed
johlju opened this issue Nov 21, 2020 · 4 comments · Fixed by #1652 or #1550
Closed

SqlLogin: Integration tests fails intermittently #1634

johlju opened this issue Nov 21, 2020 · 4 comments · Fixed by #1652 or #1550
Labels
bug The issue is a bug. tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Nov 21, 2020

The integration tests for SqlLogin fails intermittently.

2020-11-21T11:11:23.7970129Z VERBOSE: [WIN-U9C4GIKUSPU]: LCM:  [ Start  Get      ]      
2020-11-21T11:11:24.1770576Z       [-] Should be able to call Get-DscConfiguration without throwing 429ms
2020-11-21T11:11:24.2982432Z         Expected no exception to be thrown, but an exception "Connecting to remote server localhost failed with the following error message : Illegal operation attempted on a registry key that has been marked for deletion. For more information, see the about_Remote_Troubleshooting Help topic." was thrown from D:\a\1\s\tests\Integration\DSC_SqlLogin.Integration.Tests.ps1:99 char:52
2020-11-21T11:11:24.2997509Z             + ... urrentConfiguration = Get-DscConfiguration -Verbose -ErrorAction Stop
2020-11-21T11:11:24.3013810Z             +                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
2020-11-21T11:11:24.3030094Z         100:                 } | Should -Not -Throw
2020-11-21T11:11:24.3047710Z         at <ScriptBlock>, D:\a\1\s\tests\Integration\DSC_SqlLogin.Integration.Tests.ps1: line 98
2020-11-21T11:11:24.3455255Z       [-] Should have set the resource and all the parameters should match 29ms
2020-11-21T11:11:24.3494829Z         Expected 'Present', but got $null.
2020-11-21T11:11:24.3517690Z         109:                 $resourceCurrentState.Ensure | Should -Be 'Present'
2020-11-21T11:11:24.3553176Z         at <ScriptBlock>, D:\a\1\s\tests\Integration\DSC_SqlLogin.Integration.Tests.ps1: line 109

Originally posted by @Fiander in #1631 (comment)
@johlju
Copy link
Member Author

johlju commented Nov 21, 2020

I think the problem is the tests run too fast and the build worker can't keep up sometimes. Something doesn't return to the correct state fast enough. It become better after adding Wait-ForIdleLcm but still see those issues. Might help if we pasue a bit longer after LCM becomes idle. 🤔

SqlServerDsc/tests/TestHelpers/CommonTestHelper.psm1

Lines 395 to 406 in 56ebcfe

function Wait-ForIdleLcm
{
[CmdletBinding()]
param ()
while ((Get-DscLocalConfigurationManager).LCMState -ne 'Idle')
{
Write-Verbose -Message 'Waiting for the LCM to become idle'
Start-Sleep -Seconds 2
}
}

Maybe we should call Clear-DscLcmConfiguration inside Wait-ForIdleLcm. 🤔 It is normally run at the end of the tests, but those tests that run multiple integration tests might need top have after each test. 🤔
https://github.com/dsccommunity/DscResource.Test/blob/619249435884093da51d9316e07073d573975154/source/Public/Clear-DscLcmConfiguration.ps1

@johlju johlju added bug The issue is a bug. tests The issue or pull request is about tests only. labels Nov 21, 2020
@johlju johlju changed the title SQLLogin: Integration tests fails intermittently SqlLogin: Integration tests fails intermittently Dec 13, 2020
@SphenicPaul SphenicPaul mentioned this issue Dec 15, 2020
Merged
9 tasks
johlju pushed a commit that referenced this issue Jan 12, 2021
@SphenicPaul
SqlLogin: Added and amended integration tests for logins of 'SqlLogin…
9130c05 
…' type (#1652)

- SqlLogin
  - Added functionality to throw exception if an update to the `LoginMustChangePassword`
    value on an existing SQL Login is attempted. This functionality is not supported
    by referenced, SQL Server Management Object (SMO), libraries and cannot be
    supported directly by this module.
  - Added integration tests to ensure that an added (or updated) `SqlLogin` can
    connect into a SQL instance once added (or updated).
  - Added integration tests to ensure that the default database connected to by
    a `SqlLogin` is the same as specified in the resource's `DefaultDatabase`
    property/parameter.
  - Reversed order in which `PasswordExpirationEnabled` and `PasswordPolicyEnforced`
    are updated within `SqlLogin` resource. `PasswordPolicyEnforced` is now updated
    first.
  - Added integration tests to assert `LoginPasswordExpirationEnabled`,
    `LoginPasswordPolicyEnforced` and `LoginMustChangePassword` properties/parameters
    are applied and updated correctly. Similar integration tests also added to ensure
    the password of the `SqlLogin` is updated if the password within the `SqlCredential`
    value/object is changed (issue #361, issue #1032, and issue #1050).
  - Updated `SqlLogin`, integration tests to make use of amended `Wait-ForIdleLcm`,
    helper function, `-Clear` switch usage to remove intermittent, integration
    test failures (issue #1634).
@Fiander
Copy link
Contributor

Fiander commented Jan 29, 2021 •
edited by johlju
Loading

@johlju @SphenicPaul
To bad. just had a new one.

2021-01-29T19:54:51.4776075Z 'SqlServer' with version '21.1.18235' from path 'C:\Program 
2021-01-29T19:54:51.4777027Z Files\WindowsPowerShell\Modules\SqlServer\21.1.18235\SqlServer.psm1'. (SQLCOMMON0025)
2021-01-29T19:54:51.4784356Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] Connecting as current user 
2021-01-29T19:54:51.4787434Z 'WIN-U8J3HG3J1KM\SqlAdmin' using integrated security. (SQLCOMMON0054)
2021-01-29T19:54:51.4804854Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] Connected to SQL instance 
2021-01-29T19:54:51.4808768Z 'WIN-U8J3HG3J1KM\DSCSQLTEST'. (SQLCOMMON0018)
2021-01-29T19:54:51.5585261Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] It does not exist a database named
2021-01-29T19:54:51.5586404Z  'DefaultDb'.
2021-01-29T19:54:51.5616139Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] Expected the database 'DefaultDb' 
2021-01-29T19:54:51.5617168Z to present, but it was absent
2021-01-29T19:54:51.5787392Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Test     ]  [[SqlDatabase]DefaultDb_Test]  in 9.6580 seconds.
2021-01-29T19:54:51.5812975Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Set      ]  [[SqlDatabase]DefaultDb_Test]
2021-01-29T19:54:52.2531103Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] Found PowerShell module SqlServer 
2021-01-29T19:54:52.2531771Z already imported in the session. (SQLCOMMON0026)
2021-01-29T19:54:52.2547666Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] Connecting as current user 
2021-01-29T19:54:52.2549079Z 'WIN-U8J3HG3J1KM\SqlAdmin' using integrated security. (SQLCOMMON0054)
2021-01-29T19:54:52.2569167Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] Connected to SQL instance 
2021-01-29T19:54:52.2570823Z 'WIN-U8J3HG3J1KM\DSCSQLTEST'. (SQLCOMMON0018)
2021-01-29T19:54:52.2618263Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlDatabase]DefaultDb_Test] Creating the database 'DefaultDb'.
2021-01-29T19:54:53.5058980Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Set      ]  [[SqlDatabase]DefaultDb_Test]  in 1.9190 seconds.
2021-01-29T19:54:53.5063936Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Resource ]  [[SqlDatabase]DefaultDb_Test]
2021-01-29T19:54:53.5162137Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Set      ]
2021-01-29T19:54:53.5167077Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Set      ]    in  50.0570 seconds.
2021-01-29T19:54:53.5216638Z VERBOSE: Operation 'Invoke CimMethod' complete.
2021-01-29T19:54:53.5244452Z VERBOSE: Time taken for configuration job to complete is 50.107 seconds
2021-01-29T19:54:53.5734423Z       [+] Should compile and apply the MOF without throwing 50.85s
2021-01-29T19:54:53.8071861Z WARNING: There is no operation running currently. Stop will return without any action.
2021-01-29T19:54:54.4400681Z 
2021-01-29T19:54:54.4419892Z     Context When using configuration DSC_SqlLogin_AddLoginDscUser1_Config
2021-01-29T19:54:54.8413131Z VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = 
2021-01-29T19:54:54.8413738Z SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = 
2021-01-29T19:54:54.8414533Z root/Microsoft/Windows/DesiredStateConfiguration'.
2021-01-29T19:54:54.8640048Z VERBOSE: An LCM method call arrived from computer WIN-U8J3HG3J1KM with user sid 
2021-01-29T19:54:54.8640997Z S-1-5-21-3425996080-1764802727-1362500235-500.
2021-01-29T19:54:54.8745200Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Set      ]
2021-01-29T19:54:55.1175454Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Resource ]  [[SqlLogin]Integration_Test]
2021-01-29T19:54:55.1211044Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Test     ]  [[SqlLogin]Integration_Test]
2021-01-29T19:54:55.2297392Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Test     ]  [[SqlLogin]Integration_Test]  in 0.1480 seconds.
2021-01-29T19:54:55.3409959Z       [-] Should compile and apply the MOF without throwing 807ms
2021-01-29T19:54:55.4166326Z         Expected no exception to be thrown, but an exception "Connecting to remote server localhost failed with the following error message : Illegal operation attempted on a registry key that has been marked for deletion. For more information, see the about_Remote_Troubleshooting Help topic." was thrown from D:\a\1\s\tests\Integration\DSC_SqlLogin.Integration.Tests.ps1:93 char:21
2021-01-29T19:54:55.4180645Z             + ...               Start-DscConfiguration @startDscConfigurationParameters
2021-01-29T19:54:55.4196146Z             +                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
2021-01-29T19:54:55.4211475Z         94:                 } | Should -Not -Throw
2021-01-29T19:54:55.4228508Z         at <ScriptBlock>, D:\a\1\s\tests\Integration\DSC_SqlLogin.Integration.Tests.ps1: line 75
2021-01-29T19:54:55.4415785Z VERBOSE: An LCM method call arrived from computer WIN-U8J3HG3J1KM with user sid 
2021-01-29T19:54:55.4418686Z S-1-5-21-3425996080-1764802727-1362500235-500.
2021-01-29T19:54:55.4490900Z WARNING: [WIN-U8J3HG3J1KM]:                            [] The GET operation will be carried against a pending 
2021-01-29T19:54:55.4493132Z configuration since the latest configuration has not converged yet.
2021-01-29T19:54:55.5386249Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Get      ]      
2021-01-29T19:54:59.0756666Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Getting the login 
2021-01-29T19:54:59.0759306Z 'WIN-U8J3HG3J1KM\DscUser1' from the instance 'WIN-U8J3HG3J1KM\DSCSQLTEST'.
2021-01-29T19:54:59.0766328Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Preferred module SqlServer found. 
2021-01-29T19:54:59.0770277Z (SQLCOMMON0023)
2021-01-29T19:55:02.9929198Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Importing PowerShell module 
2021-01-29T19:55:02.9930610Z 'SqlServer' with version '21.1.18235' from path 'C:\Program 
2021-01-29T19:55:02.9931521Z Files\WindowsPowerShell\Modules\SqlServer\21.1.18235\SqlServer.psm1'. (SQLCOMMON0025)
2021-01-29T19:55:02.9933119Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Connecting as current user 
2021-01-29T19:55:02.9934071Z 'WIN-U8J3HG3J1KM\SqlAdmin' using integrated security. (SQLCOMMON0054)
2021-01-29T19:55:02.9934881Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Connected to SQL instance 
2021-01-29T19:55:02.9935673Z 'WIN-U8J3HG3J1KM\DSCSQLTEST'. (SQLCOMMON0018)
2021-01-29T19:55:03.1437787Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] The login 
2021-01-29T19:55:03.1439488Z 'WIN-U8J3HG3J1KM\DscUser1' is Absent at the instance 'WIN-U8J3HG3J1KM\DSCSQLTEST'.
2021-01-29T19:55:03.1732139Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Get      ]  [[SqlLogin]Integration_Test]  in 7.5870 seconds.
2021-01-29T19:55:03.1975135Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Get      ]    in  7.7480 seconds.
2021-01-29T19:55:03.3303989Z       [+] Should be able to call Get-DscConfiguration without throwing 7.89s
2021-01-29T19:55:03.4019757Z       [-] Should have set the resource and all the parameters should match 57ms
2021-01-29T19:55:03.4071012Z         Expected strings to be the same, but they were different.
2021-01-29T19:55:03.4087684Z         Expected length: 7
2021-01-29T19:55:03.4107255Z         Actual length:   6
2021-01-29T19:55:03.4122314Z         Strings differ at index 0.
2021-01-29T19:55:03.4185290Z         Expected: 'Present'
2021-01-29T19:55:03.4260525Z         But was:  'Absent'
2021-01-29T19:55:03.4280325Z         109:                 $resourceCurrentState.Ensure | Should -Be 'Present'
2021-01-29T19:55:03.4322173Z         at <ScriptBlock>, D:\a\1\s\tests\Integration\DSC_SqlLogin.Integration.Tests.ps1: line 109
2021-01-29T19:55:03.4416941Z VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = TestConfiguration,'className' 
2021-01-29T19:55:03.4420342Z = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
2021-01-29T19:55:03.4654547Z VERBOSE: An LCM method call arrived from computer WIN-U8J3HG3J1KM with user sid 
2021-01-29T19:55:03.4656448Z S-1-5-21-3425996080-1764802727-1362500235-500.
2021-01-29T19:55:03.4725716Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Test     ]
2021-01-29T19:55:03.4776765Z WARNING: [WIN-U8J3HG3J1KM]:                            [] The TEST operation will be carried against a pending 
2021-01-29T19:55:03.4778708Z configuration since the latest configuration has not converged yet.
2021-01-29T19:55:03.6947028Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Resource ]  [[SqlLogin]Integration_Test]
2021-01-29T19:55:03.6997377Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Test     ]  [[SqlLogin]Integration_Test]
2021-01-29T19:55:07.7292873Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Determines if the login 
2021-01-29T19:55:07.7294890Z 'WIN-U8J3HG3J1KM\DscUser1' at the instance 'WIN-U8J3HG3J1KM\DSCSQLTEST' has the correct state.
2021-01-29T19:55:07.7313329Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Getting the login 
2021-01-29T19:55:07.7316681Z 'WIN-U8J3HG3J1KM\DscUser1' from the instance 'WIN-U8J3HG3J1KM\DSCSQLTEST'.
2021-01-29T19:55:07.7373244Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Preferred module SqlServer found. 
2021-01-29T19:55:07.7375857Z (SQLCOMMON0023)
2021-01-29T19:55:11.5105644Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Importing PowerShell module 
2021-01-29T19:55:11.5106768Z 'SqlServer' with version '21.1.18235' from path 'C:\Program 
2021-01-29T19:55:11.5107933Z Files\WindowsPowerShell\Modules\SqlServer\21.1.18235\SqlServer.psm1'. (SQLCOMMON0025)
2021-01-29T19:55:11.5111314Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Connecting as current user 
2021-01-29T19:55:11.5113703Z 'WIN-U8J3HG3J1KM\SqlAdmin' using integrated security. (SQLCOMMON0054)
2021-01-29T19:55:11.5121950Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Connected to SQL instance 
2021-01-29T19:55:11.5125967Z 'WIN-U8J3HG3J1KM\DSCSQLTEST'. (SQLCOMMON0018)
2021-01-29T19:55:11.5895515Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] The login 
2021-01-29T19:55:11.5897354Z 'WIN-U8J3HG3J1KM\DscUser1' is Absent at the instance 'WIN-U8J3HG3J1KM\DSCSQLTEST'.
2021-01-29T19:55:11.5917596Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] The login 
2021-01-29T19:55:11.5918351Z 'WIN-U8J3HG3J1KM\DscUser1' is Absent, but expected it to be Present.
2021-01-29T19:55:11.6068930Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Test     ]  [[SqlLogin]Integration_Test] False in 8.0020 seconds.
2021-01-29T19:55:11.6094201Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Resource ]  [[SqlLogin]Integration_Test]
2021-01-29T19:55:11.6141200Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Test     ]     Completed processing test operation. The operation returned 
2021-01-29T19:55:11.6144545Z False.
2021-01-29T19:55:11.6156068Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ End    Test     ]    in  8.1490 seconds.
2021-01-29T19:55:11.6454851Z VERBOSE: Operation 'Invoke CimMethod' complete.
2021-01-29T19:55:11.6468361Z VERBOSE: Time taken for configuration job to complete is 8.208 seconds
2021-01-29T19:55:11.6679100Z       [-] Should return $true when Test-DscConfiguration is run 8.22s
2021-01-29T19:55:11.6838715Z         Expected strings to be the same, but they were different.
2021-01-29T19:55:11.6856419Z         Expected length: 4
2021-01-29T19:55:11.6870893Z         Actual length:   5
2021-01-29T19:55:11.6889797Z         Strings differ at index 0.
2021-01-29T19:55:11.6946191Z         Expected: 'True'
2021-01-29T19:55:11.6990597Z         But was:  'False'
2021-01-29T19:55:11.6991456Z         116:                 Test-DscConfiguration -Verbose | Should -Be 'True'
2021-01-29T19:55:11.6992492Z         at <ScriptBlock>, D:\a\1\s\tests\Integration\DSC_SqlLogin.Integration.Tests.ps1: line 116
2021-01-29T20:06:45.8678479Z WARNING: There is no operation running currently. Stop will return without any action.
2021-01-29T20:06:46.5620210Z 
2021-01-29T20:06:46.5641932Z     Context When using configuration DSC_SqlLogin_AddLoginDscUser2_Config
2021-01-29T20:06:46.9565050Z VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = 
2021-01-29T20:06:46.9566700Z SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = 
2021-01-29T20:06:46.9573092Z root/Microsoft/Windows/DesiredStateConfiguration'.
2021-01-29T20:06:46.9869983Z VERBOSE: An LCM method call arrived from computer WIN-U8J3HG3J1KM with user sid 
2021-01-29T20:06:46.9877657Z S-1-5-21-3425996080-1764802727-1362500235-500.
2021-01-29T20:06:46.9878825Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Set      ]
2021-01-29T20:06:47.0868688Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Resource ]  [[SqlLogin]Integration_Test]
2021-01-29T20:06:47.1339529Z VERBOSE: [WIN-U8J3HG3J1KM]: LCM:  [ Start  Test     ]  [[SqlLogin]Integration_Test]
2021-01-29T20:06:50.4485756Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Determines if the login 
2021-01-29T20:06:50.4490002Z 'WIN-U8J3HG3J1KM\DscUser2' at the instance 'WIN-U8J3HG3J1KM\DSCSQLTEST' has the correct state.
2021-01-29T20:06:50.4611326Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Getting the login 
2021-01-29T20:06:50.4612807Z 'WIN-U8J3HG3J1KM\DscUser2' from the instance 'WIN-U8J3HG3J1KM\DSCSQLTEST'.
2021-01-29T20:06:50.4619593Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Preferred module SqlServer found. 
2021-01-29T20:06:50.4626980Z (SQLCOMMON0023)
2021-01-29T20:06:54.1238652Z VERBOSE: [WIN-U8J3HG3J1KM]:                            [[SqlLogin]Integration_Test] Importing PowerShell module

@johlju
Copy link
Member Author

johlju commented Jan 30, 2021

Reopening this issue. We had hoped we squashed that one. Let's keep track if there is always line 93 in the SqlLogin integration test that fails, or if the exception moves. If it doesn't move, then maybe we need wait for longer after applying the configuration DSC_SqlLogin_CreateDependencies_Config. 🤔

@johlju johlju reopened this Jan 30, 2021
@johlju johlju added the help wanted The issue is up for grabs for anyone in the community. label Jan 30, 2021
@johlju
Copy link
Member Author

johlju commented Apr 14, 2022

When converting the unit and integration tests to Pester 5 and pushed new commits countless times (well a lot any way) I have not seen this issue, so I will auto-close this issue when the Pester 5 conversion PR is merged.

@johlju johlju mentioned this issue Apr 14, 2022
Merged
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 14, 2022
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug. tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
2 participants
@johlju @Fiander