BREAKING CHANGE: SqlServerEndpoint: Added the property State

[johlju]

Pull Request (PR) description

• SqlServerEndpointState
  • This resource is now deprecated. The functionality is covered by a
    property in the resource SqlServerEndpoint (issue BREAKING CHANGE: SqlServerEndpointState: This should be rolled into the SqlServerEndpoint resource #968).
• SqlServerEndpoint
  • BREAKING CHANGE: A new required property EndpointType was added to
    support different types of endpoints in the future. For now the only
    endpoint type that is supported is the database mirror endpoint type
    (DatabaseMirroring).
  • Added the property State to be able to specify if the endpoint should
    be running, stopped, or disabled. This property was moved from the now
    deprecated DSC resource SqlServerEndpointState.
  • BREAKING CHANGE: Now the properties are only enforced if they are
    specified in the configuration.
• CommonTestHelper
  • The test helper function New-SQLSelfSignedCertificate was changed
    to install the dependent module PSPKI through RequiredModules.psd1.

This Pull Request (PR) fixes the following issues

• Fixes BREAKING CHANGE: SqlServerEndpointState: This should be rolled into the SqlServerEndpoint resource #968
• Closes SqlServerEndpointState: Should Be Cluster Aware #880
• Closes SqlServerEndpointState: Integration test is missing for this resource #746

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1535 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1535   +/-   ##
======================================
- Coverage      98%     98%   -1%     
======================================
  Files          37      36    -1     
  Lines        5866    5830   -36     
======================================
- Hits         5758    5722   -36     
  Misses        108     108           

[johlju]

Reviewable status: 0 of 25 files reviewed, 1 unresolved discussion

---

CHANGELOG.md, line 13 at r1 (raw file):

Removed resource _SqlServerEndpointState_

We should just deprecate the resource like SqlServerNetwork.

[johlju]

Reviewed 1 of 25 files at r1, 1 of 10 files at r2.
Reviewable status: 2 of 30 files reviewed, all discussions resolved

---

CHANGELOG.md, line 13 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Removed resource _SqlServerEndpointState_

We should just deprecate the resource like SqlServerNetwork.

Done

[johlju]

Reviewed 19 of 25 files at r1, 9 of 10 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions

---

source/SqlServerDsc.psd1, line 63 at r2 (raw file):

        'SqlServerEndpointState'
.        ...
        'SqlServerNetwork'

These should not be removed.

---

tests/Integration/DSC_SqlServerEndPoint.config.ps1, line 54 at r2 (raw file):

            Owner                = $Node.Owner
            State                = 'Started'

Should rename file, wrongly renamed back again to EndPoint instead of Endpoint.

[johlju]

Reviewable status: 27 of 29 files reviewed, all discussions resolved (waiting on @johlju)

---

source/SqlServerDsc.psd1, line 63 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

        'SqlServerEndpointState'
.        ...
        'SqlServerNetwork'

These should not be removed.

Done

---

tests/Integration/DSC_SqlServerEndPoint.config.ps1, line 54 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should rename file, wrongly renamed back again to EndPoint instead of Endpoint.

Done

[johlju]

Reviewed 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved