Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlServerEndpointState: This should be rolled into the SqlServerEndpoint resource #968

Closed
johlju opened this issue Dec 24, 2017 · 0 comments · Fixed by #1535
Closed

BREAKING CHANGE: SqlServerEndpointState: This should be rolled into the SqlServerEndpoint resource #968

johlju opened this issue Dec 24, 2017 · 0 comments · Fixed by #1535
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Dec 24, 2017

Details of the scenario you tried and the problem that is occurring:
When work was done renaming resources (in issue #851), there was some suggestions that I thought should become separate issues.

One suggestion was that the resource SqlServerEndpointState should be merged into SqlServerEndpoint resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 24, 2017
@johlju johlju mentioned this issue May 8, 2020
Merged
9 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 8, 2020
johlju added a commit that referenced this issue May 13, 2020
@johlju
BREAKING CHANGE: SqlServerEndpoint: Added the property State (#1535)
4c0dcc6 
- SqlServerEndpointState
  - This resource is now deprecated. The functionality is covered by a
    property in the resource _SqlServerEndpoint_ (issue #968).
- SqlServerEndpoint
  - BREAKING CHANGE: A new required property `EndpointType` was added to
    support different types of endpoints in the future. For now the only
    endpoint type that is supported is the database mirror endpoint type
    (`DatabaseMirroring`).
  - Added the property `State` to be able to specify if the endpoint should
    be running, stopped, or disabled. _This property was moved from the now_
    _deprecated DSC resource `SqlServerEndpointState`_.
  - BREAKING CHANGE: Now the properties are only enforced if they are
    specified in the configuration.
- CommonTestHelper
  - The test helper function `New-SQLSelfSignedCertificate` was changed
    to install the dependent module `PSPKI` through `RequiredModules.psd1`.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlServerEndpoint: Added the property State johlju/SqlServerDsc
1 participant
@johlju