Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Merge integration tests into the same script #1296

Merged
merged 2 commits into from
Mar 5, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Feb 28, 2019

Pull Request (PR) description

No change log entry was added because there are already suitable change log entries.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Feb 28, 2019
@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #1296 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1296   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        35      35           
  Lines      4432    4432           
====================================
  Hits       4327    4327           
  Misses      105     105

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju
Copy link
Member Author

johlju commented Mar 5, 2019

For some reason CLA did not get reported. Closing and reopening PR to kick off the CLA bot again.

@johlju johlju closed this Mar 5, 2019
@johlju johlju reopened this Mar 5, 2019
@johlju johlju merged commit 40e746c into dsccommunity:dev Mar 5, 2019
@johlju johlju deleted the fix-issue-1287 branch March 6, 2019 17:12
@johlju johlju removed the needs review The pull request needs a code review. label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants