Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Integration tests for SQL Server 2016 and SQL Server 2017 should use the same test config- and script file #1291

Closed
johlju opened this issue Feb 25, 2019 · 0 comments · Fixed by #1296
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Feb 25, 2019

Details of the scenario you tried and the problem that is occurring

The integration tests for SqlSetup is run in two jobs, one job for SQL Server 2016 and another job for SQL Server 2017. To simplify coding during the PR #1103 the integration test script file and config file was copied and split into two integration script- and config files.
These should be concatenated so that SQL Server 2016 and SQL Server 2017 (and future versions like SQL Server 2019) is tested in the same integration test script- and config file.

Verbose logs showing the problem

n/a

Suggested solution to the issue

n/a

The DSC configuration that is used to reproduce the issue (as detailed as possible)

n/a

SQL Server edition and version the target node is running

n/a

SQL Server PowerShell modules present on the target node

n/a

The operating system the target node is running

n/a

Version and build of PowerShell the target node is running

n/a

Version of the DSC module that was used ('dev' if using current dev branch)

dev

@johlju johlju changed the title SqlSetup: Integration tests fron SQL Server 2016 and SQL Server 2017 should use the same config file and test script file SqlSetup: Integration tests for SQL Server 2016 and SQL Server 2017 should use the same config file and test script file Feb 25, 2019
@johlju johlju changed the title SqlSetup: Integration tests for SQL Server 2016 and SQL Server 2017 should use the same config file and test script file SqlSetup: Integration tests for SQL Server 2016 and SQL Server 2017 should use the same config- and test script file Feb 25, 2019
@johlju johlju changed the title SqlSetup: Integration tests for SQL Server 2016 and SQL Server 2017 should use the same config- and test script file SqlSetup: Integration tests for SQL Server 2016 and SQL Server 2017 should use the same test config- and script file Feb 25, 2019
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only. labels Feb 25, 2019
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant