SqlSetup: Connect-SQLAnalysis no longer using LoadWithPartialName()

[johlju]

Pull Request (PR) description

• Now the correct assembly should load when using the helper function
  Connect-SQLAnalysis. Previously is was using LoadWithPartialName() which
  meant that it would load the first assembly in GAC, regardless of which
  PowerShell module was used (SQLPS or SqlSever).

This Pull Request (PR) fixes the following issues

Maybe helps with issue #812.

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md? Entry
  should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md?
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help?
• Comment-based help added/updated?
• Localization strings added/updated in all localization files as appropriate?
• Examples appropriately added/updated?
• Unit tests added/updated?
  See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible)?
  See DSC Resource Testing Guidelines.
• New/changed code adheres to
  DSC Resource Style Guidelines
  and Best Practices?

---

This change is 

[johlju]

Wasn't so easy as I thought, have to get back to this at another time.

Failing on this when using SQLPS module:

VERBOSE: INTEGRATION ERROR MESSAGE: PowerShell DSC resource MSFT_SqlSetup  failed to execute Set-TargetResource functionality with error message: System.InvalidOperationException: Failed to connected to Analysis Services instance 'APPVYR-WIN\DSCTABULAR'. ---> System.Management.Automation.PSArgumentException: Cannot find type [Microsoft.AnalysisServices.Server]: verify that the assembly containing this type is loaded.

[codecov-io]

Codecov Report

Merging #1150 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            dev   #1150    +/-   ##
=====================================
+ Coverage    98%     98%   +<1%     
=====================================
  Files        36      36            
  Lines      4830    4840    +10     
=====================================
+ Hits       4756    4766    +10     
  Misses       74      74

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[johlju]

So the problem with removing LoadWithPartial is that the module SQLPS does not load the type Microsoft.AnalysisServices.Server, and I can't find a way to load it. Although, if we install the module SqlServer and use that it works, because SqlServer do load the type. But using that moduel as a requirement is a breaking change.
But I do want to remove LoadWithPartial as it has problem using that. I will change the integration tests to install the SqlServer module and we see where we are from there.

[johlju]

I going in the direction of require the SqlServer module for working with Analysis Services, unless someone know another way of loading the types (without using LoadWithPartial).
But for me to do that we need to have a resource for downloading modules, and that is in the works in the PowerShellGet repo.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[johlju]

The resource PSModule has been released in the latest PowerShellGet module. So now we can move forward with this PR I think. But this will be a breaking change, as it no longer will support the SQLPS module, but only the SqlServer module. Because the SqlServer module correctly loads the correct assemblies needed to not have to do LoadWithPartial().

[johlju]

Added this new functionality under a feature flag; 'AnalysisServicesConnection'. This makes it to be a non-breaking change this release. In a future release we can make this the default.

[johlju]

Closing a reopening to kick off the tests.

[johlju]

Closing this PR due to inactivity. If there are someone who wants to work on this issue or PR please open a new PR.