Changes to SqlSetup

- Now the correct assembly should load when using the helper function Connect-SQLAnalysis. Previously is was using LoadWithPartialName() which meant that it would load the first assembly in GAC, regardless of which PowerShell module was used (SQLPS or SqlSever).
dsccommunity · Jul 30, 2018 · 86e076f · 86e076f
1 parent 6d42512
commit 86e076f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+- Changes to SqlSetup
+  - Now the correct assembly should load when using the helper function
+    Connect-SQLAnalysis. Previously is was using LoadWithPartialName() which
+    meant that it would load the first assembly in GAC, regardless of which
+    PowerShell module was used (SQLPS or SqlSever).
+
 ## 11.4.0.0
 
 - Changes to SqlServerDsc

diff --git a/SqlServerDscHelper.psm1 b/SqlServerDscHelper.psm1
@@ -132,7 +132,7 @@ function Connect-SQLAnalysis
         $SetupCredential
     )
 
-    $null = [System.Reflection.Assembly]::LoadWithPartialName('Microsoft.AnalysisServices')
+    Import-SQLPSModule
 
     if ($SQLInstanceName -eq 'MSSQLSERVER')
     {

diff --git a/Tests/Unit/SqlServerDSCHelper.Tests.ps1 b/Tests/Unit/SqlServerDSCHelper.Tests.ps1
@@ -438,6 +438,10 @@ InModuleScope $script:moduleName {
     }
 
     Describe 'Testing Connect-SQLAnalysis' {
+        BeforeAll {
+            Mock -CommandName Import-SQLPSModule
+        }
+
         BeforeEach {
             Mock -CommandName New-InvalidOperationException -MockWith $mockThrowLocalizedMessage -Verifiable
             Mock -CommandName New-Object `