-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlDatabaseUser: New resource #846
Comments
I agree to rename this resource, and change so that this resource only handles creation and dropping of database user. This must be merged at the same time (or close to the same time) as the issue #847 is merged. |
Practically, to be able to create a PR for this issue and issue #847, I think it would be best to not rename this resource but instead, if it helps, copy the code from the xSQLServerDatabaseRole to the new resource xSQLServerDatabaseUser and change the code there. This will make it possible to change to xSQLServerDatabaseRole without merge conflicts. |
This is the proposed schema. Please comment if you see anything that needs to be changed.
|
- Changes to SqlServerDsc - New DSC resource SqlDatabaseUser (issue #846). - Adds ability to create database users with more fine-grained control, e.g. re-mapping of orphaned logins or a different login. Supports creating a user with or without login name, and database users mapped to a certificate or asymmetric key. - Minor style fixes in unit tests. - Changes to SqlDatabase - Get-TargetResource now correctly return `$null` for the collation property when the database does not exist (issue #1395). - No longer enforces the collation property if the Collation parameter is not part of the configuration (issue #1396). - Updated resource description in README.md - Fix examples to use `PsDscRunAsCredential` (issue #760). - Added integration tests (issue #739). - Updated unit tests to the latest template (issue #1068).
xSQLServerDatabaseRole currently handles DB user creation and role assignment (for already existing roles)
The name is a bit confusing, since the name implies the resource actually handles DB roles creation/removal.
I suggest we rename xSQLServerDatabaseRole to XSQLServerDatabaseUser.
The new resource xSQLServerDatabaseRole would then handle DB roles.
The text was updated successfully, but these errors were encountered: