Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlDatabase: Integration test is missing for this resource #739

Closed
johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #1391
Closed

SqlDatabase: Integration test is missing for this resource #739

johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #1391
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Aug 13, 2017

Details of the scenario you tried and the problem that is occurring:
We should add an integration test for this resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Aug 13, 2017
@johlju johlju changed the title xSQLServerDatabase: Integration test is missing for this resource SqlDatabase: Integration test is missing for this resource Dec 23, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 15, 2019
@pshamus pshamus mentioned this issue Jul 15, 2019
Merged
9 tasks
johlju pushed a commit that referenced this issue Jul 17, 2019
@pshamus @johlju
SqlDatabaseUser: New DSC resource (#1391)
bb95eb8 
- Changes to SqlServerDsc
  - New DSC resource SqlDatabaseUser (issue #846).
    - Adds ability to create database users with more fine-grained control,
      e.g. re-mapping of orphaned logins or a different login. Supports
      creating a user with or without login name, and database users mapped
      to a certificate or asymmetric key.
  - Minor style fixes in unit tests.
- Changes to SqlDatabase
  - Get-TargetResource now correctly return `$null` for the collation property
    when the database does not exist (issue #1395).
  - No longer enforces the collation property if the Collation parameter
    is not part of the configuration (issue #1396).
  - Updated resource description in README.md
  - Fix examples to use `PsDscRunAsCredential` (issue #760).
  - Added integration tests (issue #739).
  - Updated unit tests to the latest template (issue #1068).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlDatabaseUser: New DSC resource pshamus/SqlServerDsc
1 participant
@johlju