Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: xSQLServer: Remove support for WMF 4.0 (PowerShell 4.0) #574

Closed
johlju opened this issue May 24, 2017 · 5 comments · Fixed by #578
Closed

BREAKING CHANGE: xSQLServer: Remove support for WMF 4.0 (PowerShell 4.0) #574

johlju opened this issue May 24, 2017 · 5 comments · Fixed by #578
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented May 24, 2017

Are there users out there that still needs WMF 4.0?

Should we remove support for WMF 4.0 and makes this module WMF 5.x only? Meaning that if it works for WMF 4.0, then great, if it doesn't then we won't make an effort to make it work.

To support PowerShell 4.0 across the entire module will require a lot of work.

We have discussed this in various issues. We have also discussed this in the Community Calls where it was said, more or less, that generally it's okay to only support WMF 5.x, but if a resource can support PowerShell 4.0 then that would be better.
@johlju johlju added the discussion The issue is a discussion. label May 24, 2017
@Zuldan
Copy link

Zuldan commented May 24, 2017

@johlju My thoughts are WMF 4 support can be dropped. There should be no reason why anyone hasn't upgraded their servers to WMF 5.1 (better performance and better security) unless your running Exchange and no one runs SQL Server on an Exchange Server. Your spending a lot of your time trying to maintain WMF 4 support. Your time is precious. If someone really wants WMF 4 support they can always download the older versions of xSQLServer.

@randomnote1
Copy link
Contributor

When I submit the pull request for the availability group database membership resource, that will force the module to require WMF 5. I wrote it as a class based resource. I'm working on the unit tests now which are proving to be fun!

@johlju
Copy link
Member Author

johlju commented May 25, 2017

@Zuldan I though along those lines as well, that they can download an old version. Just want to make sure it is not an overwhelming need for WMF 4.0. But I would be surprised if it was.

@randomnote1 Do you mean the entire module, just not that resource? If you actually mean the entire module will require WMF 5.x, then that will tip the scale in favor of removing support for WMF 4.0.
Just curious what makes the entire module require WMF 5.x? Is it something in the .psd1 and how the module will be loaded?

@randomnote1 I'm looking forward to seeing that resource and the tests! It will be a new experience reviewing that code. 😄

@johlju johlju mentioned this issue May 25, 2017
Merged
5 tasks
@randomnote1
Copy link
Contributor

Yes, the entire module. PowerShell 4 can't import the module if there's is a class based resource referenced in the psd1.

Doing the review will be interesting. There will be a few decision points required.

@johlju
Copy link
Member Author

johlju commented May 25, 2017

Ah great @randomnote1. Then we can't support WMF 4.0 anymore. I will do that in the PR I'm working on now. Then I can clean out a lot of code and texts.

@johlju johlju changed the title xSQLServer: Remove support for WMF 4.0 (PowerShell 4.0) BREAKING CHANGE: xSQLServer: Remove support for WMF 4.0 (PowerShell 4.0) May 25, 2017
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. and removed discussion The issue is a discussion. labels May 25, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 25, 2017
@johlju
Changes to xSQLServer
4eedc80 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
@johlju johlju mentioned this issue May 25, 2017
Merged
5 tasks
@johlju johlju self-assigned this May 25, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 27, 2017
@johlju
Changes to xSQLServer
834225a 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 30, 2017
@johlju
Changes to xSQLServer
f6d447a 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 3, 2017
@johlju
Changes to xSQLServer
a5636d2 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 4, 2017
@johlju
Changes to xSQLServer
15cc970 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 5, 2017
@johlju
Changes to xSQLServer
f25c86b 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit that referenced this issue Jun 6, 2017
@johlju
BREAKING CHANGE: xSQLServer: Removed deprecated resources and WMF 4.0…
71b5cc4 
… support, xSQLServerSetup supports PsDscRunAsCredential (#578)

- Changes to xSQLServer
  - BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue #574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupJoin (issue #457).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupEnsure (issue #456).
  - BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue #336).
- Changes to xSQLServerHelper
  - Removed helper function Grant-ServerPerms because the deprecated resource that was using it was removed.
  - Removed helper function Grant-CNOPerms because the deprecated resource that was using it was removed.
  - Removed helper function New-ListenerADObject because the deprecated resource that was using it was removed.
- Changes to xSQLServerSetup
  - BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue #41, #93 and #126).
  - BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
  - BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
  - BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
  - When setup exits with the exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue #565).
  - When setup exits with an exit code other than 0 or 3010 a warning message is written to console telling that setup finished with an error (partly fixes issue #580).
  - Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue #566).
  - Updated all examples to match the removal of SetupCredential.
  - Updated (removed) severe known issues in README.md for resource xSQLServerSetup.
@johlju johlju removed their assignment Jun 6, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
3 participants
@johlju @Zuldan @randomnote1