Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlSetup: When setup exits with exit code 3010 a reboot is required #565

Closed
johlju opened this issue May 22, 2017 · 1 comment · Fixed by #1536
Closed

BREAKING CHANGE: SqlSetup: When setup exits with exit code 3010 a reboot is required #565

johlju opened this issue May 22, 2017 · 1 comment · Fixed by #1536
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented May 22, 2017

Details of the scenario you tried and the problem that is occurring:
Today when setup exits with exit code 3010 and a reboot is required, but there is no mention of that in the verbose output. In the Summery.txt log file it says

Final result: Passed but reboot required, see logs for details
Exit code (Decimal): 3010

More information in article Server setup fails with code 3010.

I suggest that the resource reboots the server when setup.exe exits with exit code 3010, unless the parameter SuppressReboot is set to $true.
If we all in agreement that the resource should reboot, then that will be a breaking change.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
All

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 22, 2017
@johlju
Copy link
Member Author

johlju commented May 22, 2017 •
edited
Loading

I found this when working on changing the setup method to handle different credentials during setup. I have changed the code so that it will print a warning that a reboot is required when exit code is 3010 (and only when SuppresReboot is set to $false). This is until we decide if this issue will automatically restart the target node (using $global:DSCMachineStatus = 1).

johlju added a commit to johlju/SqlServerDsc that referenced this issue May 25, 2017
@johlju
Changes to xSQLServer
4eedc80 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
This was referenced May 25, 2017
Merged
Open
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 27, 2017
@johlju
Changes to xSQLServer
834225a 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 30, 2017
@johlju
Changes to xSQLServer
f6d447a 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 3, 2017
@johlju
Changes to xSQLServer
a5636d2 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 4, 2017
@johlju
Changes to xSQLServer
15cc970 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 5, 2017
@johlju
Changes to xSQLServer
f25c86b 
BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue dsccommunity#574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
Changes to xSQLServerSetup
BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
When setup exits with exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue dsccommunity#565).
Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue dsccommunity#566).
johlju added a commit that referenced this issue Jun 6, 2017
@johlju
BREAKING CHANGE: xSQLServer: Removed deprecated resources and WMF 4.0…
71b5cc4 
… support, xSQLServerSetup supports PsDscRunAsCredential (#578)

- Changes to xSQLServer
  - BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue #574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupJoin (issue #457).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupEnsure (issue #456).
  - BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue #336).
- Changes to xSQLServerHelper
  - Removed helper function Grant-ServerPerms because the deprecated resource that was using it was removed.
  - Removed helper function Grant-CNOPerms because the deprecated resource that was using it was removed.
  - Removed helper function New-ListenerADObject because the deprecated resource that was using it was removed.
- Changes to xSQLServerSetup
  - BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue #41, #93 and #126).
  - BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
  - BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
  - BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
  - When setup exits with the exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue #565).
  - When setup exits with an exit code other than 0 or 3010 a warning message is written to console telling that setup finished with an error (partly fixes issue #580).
  - Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue #566).
  - Updated all examples to match the removal of SetupCredential.
  - Updated (removed) severe known issues in README.md for resource xSQLServerSetup.
@johlju johlju changed the title BREAKING CHANGE: xSQLServerSetup: When setup exits with exit code 3010 a reboot is required BREAKING CHANGE: SqlSetup: When setup exits with exit code 3010 a reboot is required Dec 22, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 9, 2020
@johlju johlju mentioned this issue May 9, 2020
Merged
9 tasks
johlju added a commit that referenced this issue May 14, 2020
@johlju
BREAKING CHANGE: SqlSetup: Restarts node if setup exits with code 3010 (
1e162d3 
#1536)

- SqlSetup
  - BREAKING CHANGE: Now, unless the parameter SuppressReboot is set to
    $true, the node will be restarted if the setup ends with the error code 3010.
    Previously just a warning message was written (issue #565).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlSetup: Restarts node if setup exits with code 3010 johlju/SqlServerDsc
1 participant
@johlju