Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerReplication: Tests report Script Analyzer warnings that need to be fixed #263

Closed
johlju opened this issue Dec 28, 2016 · 0 comments · Fixed by #969
Closed

SqlServerReplication: Tests report Script Analyzer warnings that need to be fixed #263

johlju opened this issue Dec 28, 2016 · 0 comments · Fixed by #969
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Dec 28, 2016

Details of the scenario you try and problem that is occurring:
Tests report Script Analyzer warnings that need to be fixed:

MSFT_xSQLServerReplication.psm1 (Line 445): The cmdlet 'Get-ConnectionInfoAssembly' returns an object of type 'System.Reflection.Assembly' but this type is not declared in the OutputType attribute.
MSFT_xSQLServerReplication.psm1 (Line 461): The cmdlet 'Get-RmoAssembly' returns an object of type 'System.Reflection.Assembly' but this type is not declared in the OutputType attribute.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
dev
@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Dec 28, 2016
@johlju johlju changed the title xSQLServerReplication: Tests report Script Analyzer warnings that need to be fixed SqlServerReplication: Tests report Script Analyzer warnings that need to be fixed Dec 24, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Dec 27, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 27, 2017
@johlju
Changes to SqlServerDsc
39213a5 
- Changes to SqlDatabase
  - Fix minor Script Analyzer warning.
- Changes to SqlServerReplication
  - Fix Script Analyzer warning (issue dsccommunity#263).
@johlju johlju mentioned this issue Dec 27, 2017
Merged
5 tasks
johlju added a commit that referenced this issue Dec 28, 2017
@johlju
SqlServerDsc: Fix PSSA rule warnings (#969)
ebe2a53 
- Changes to SqlDatabase
  - Fix minor Script Analyzer warning.
- Changes to SqlServerReplication
  - Fix Script Analyzer warning (issue #263).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Fix PSSA rule warnings johlju/SqlServerDsc
1 participant
@johlju