Skip to content

Commit

Permalink
SqlServerDsc: Fix PSSA rule warnings (#969)
Browse files Browse the repository at this point in the history
- Changes to SqlDatabase
  - Fix minor Script Analyzer warning.
- Changes to SqlServerReplication
  - Fix Script Analyzer warning (issue #263).
  • Loading branch information
johlju authored Dec 28, 2017
1 parent 686c1d5 commit ebe2a53
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,12 @@
- Changes to SqlAlias
- Fixed issue where exception was thrown if reg keys did not exist
([issue #949](https://github.com/PowerShell/SqlServerDsc/issues/949)).
- Changes to SqlDatabase
- Fix minor Script Analyzer warning.
- Changes to SqlServerNetwork
- Added sysadmin account parameter usage to the examples.
- Changes to SqlServerReplication
- Fix Script Analyzer warning ([issue #263](https://github.com/PowerShell/SqlServerDsc/issues/263)).
- Changes to SqlServiceAccount
- Default services are now properly detected
([issue #930](https://github.com/PowerShell/SqlServerDsc/issues/930)).
Expand Down
1 change: 0 additions & 1 deletion DSCResources/MSFT_SqlDatabase/MSFT_SqlDatabase.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ function Set-TargetResource

if ($sqlServerObject)
{

if ($Ensure -eq 'Present')
{
if (-not $PSBoundParameters.ContainsKey('Collation'))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ function Register-DistributorPublisher
function Get-ConnectionInfoAssembly
{
[CmdletBinding()]
[OutputType([System.Object])]
[OutputType([System.Reflection.Assembly])]
param(
[Parameter(Mandatory = $true)]
[System.String]
Expand All @@ -463,7 +463,7 @@ function Get-ConnectionInfoAssembly
function Get-RmoAssembly
{
[CmdletBinding()]
[OutputType([System.Object])]
[OutputType([System.Reflection.Assembly])]
param(
[Parameter(Mandatory = $true)]
[System.String]
Expand Down

0 comments on commit ebe2a53

Please sign in to comment.