Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlRSSetup: SuppressRestart added to argument list even when set to $false #1401

Closed
johlju opened this issue Jul 16, 2019 · 0 comments · Fixed by #1673
Closed

SqlRSSetup: SuppressRestart added to argument list even when set to $false #1401

johlju opened this issue Jul 16, 2019 · 0 comments · Fixed by #1673
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 16, 2019 •
edited
Loading

This is similar to issue #1398

https://github.com/PowerShell/SqlServerDsc/blob/2d37a930d957d2bbe148d118a5065a2f6f33d29e/DSCResources/MSFT_SqlRSSetup/MSFT_SqlRSSetup.psm1#L398-L403

An evaluation should be added here to make sure SuppressRestart -eq $true and only then add SuppressRestart to the argument list.
@johlju johlju added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jul 16, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jan 16, 2021
@johlju johlju mentioned this issue Jan 16, 2021
Merged
9 tasks
johlju added a commit that referenced this issue Jan 21, 2021
@johlju
SqlRSSetup: Fix SuppressRestart to not be added when $false (#1673)
c392042 
- SqlRSSetup
  - If parameter `SuppressRestart` is set to `$false` the `/norestart`
    argument is no longer wrongly added (issue #1401).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlRSSetup: Fix SuppressRestart to not be added when $false johlju/SqlServerDsc
1 participant
@johlju