SqlRSSetup: EditionUpgrade parameter bug.

[sguilbault-sherweb]

Details of the scenario you tried and the problem that is occurring

The parameter is a bool. Normally it should support $True to use it and $False to skip it. The way the ressource is built, whatever the value passed, since it's defined, it will act as if the value was set to $True. In documentation, it say the default value is $False but looking at the code it's $NULL. When the parameter isn't specified, it work as expected. I assumed the only tests that were done are with the value at $True and at $NULL.

Verbose logs showing the problem

N/A

Suggested solution to the issue

Add a test on the value to make sure is $True instead of just defined. (In the Set function at least)

The DSC configuration that is used to reproduce the issue (as detailed as possible)

N/A

SQL Server edition and version the target node is running

2017 Standard

SQL Server PowerShell modules present on the target node

N/A

The operating system the target node is running

Windows Server 2016

Version and build of PowerShell the target node is running

5.1.14393.2969
10.0.14393.2969

Version of the DSC module that was used ('dev' if using current dev branch)

13.0.0.0

[johlju]

Yes, it looks like this line is wrong

https://github.com/PowerShell/SqlServerDsc/blob/2d37a930d957d2bbe148d118a5065a2f6f33d29e/DSCResources/MSFT_SqlRSSetup/MSFT_SqlRSSetup.psm1#L405-L410

An evaluation should be added here to make sure EditionUpgrade -eq $true and only then add EditionUpgrade to the argument list.

[sguilbault-sherweb]

looking at issue list this one might also be linked #1311

[johlju]

Issue #1311 is more to find a way to detect what edition is currently installed so Test-TargetResource can handle the desired state. Since there is currently no check, EditionUpgrade = $true will not work if there is for example a Eval version installed, it will think it is in desired state even if the desired state is to have 'Dev' installed.

This issue, what I understood is that Set-TargetResource is adding the /EditionUpgrade argument even if it is $false.