dsccommunity · PlagueHO · Apr 27, 2020 · Apr 25, 2020 · Apr 26, 2020 · Apr 26, 2020
diff --git a/.MetaTestOptIn.json b/.MetaTestOptIn.json
diff --git a/.codecov.yml b/.codecov.yml
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1,10 @@
+###############################################################################
+# Set default behavior to automatically normalize line endings.
+###############################################################################
+* text eol=crlf
+
+# Ensure any exe files are treated as binary
+*.exe binary
+*.jpg binary
+*.xl* binary
+*.pfx binary
diff --git a/.gitignore b/.gitignore
@@ -2,14 +2,9 @@
 *.user
 *.coverage
 .vs
+.vscode
 .psproj
 .sln
-DscResource.Tests
-DscResource.Tests/*
-Modules/DFSDsc/DscResource.Tests
-Modules/DFSDsc/DscResource.Tests/*
-node_modules
-node_modules/*
 markdownissues.txt
 TestResults.xml
-*.config.json
+output/
diff --git a/.vscode/analyzersettings.psd1 b/.vscode/analyzersettings.psd1
@@ -1,11 +1,6 @@
 @{
-    <#
-        For the custom rules to work, the DscResource.Tests repo must be
-        cloned. It is automatically clone as soon as any unit or
-        integration tests are run.
-    #>
-    CustomRulePath = '.\DSCResource.Tests\DscResource.AnalyzerRules'
-
+    CustomRulePath      = '.\output\RequiredModules\DscResource.AnalyzerRules'
+    includeDefaultRules = $true
     IncludeRules   = @(
         # DSC Resource Kit style guideline rules.
         'PSAvoidDefaultValueForMandatoryParameter',
@@ -43,11 +38,7 @@
         'PSUseDeclaredVarsMoreThanAssignments',
         'PSUsePSCredentialType',
 
-        <#
-            This is to test all the DSC Resource Kit custom rules.
-            The name of the function-blocks of each custom rule start
-            with 'Measure*'.
-        #>
         'Measure-*'
     )
+
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,15 +1,38 @@
-// Place your settings in this file to overwrite default and user settings.
 {
     "powershell.codeFormatting.openBraceOnSameLine": false,
-    "powershell.codeFormatting.newLineAfterOpenBrace": false,
+    "powershell.codeFormatting.newLineAfterOpenBrace": true,
     "powershell.codeFormatting.newLineAfterCloseBrace": true,
     "powershell.codeFormatting.whitespaceBeforeOpenBrace": true,
     "powershell.codeFormatting.whitespaceBeforeOpenParen": true,
     "powershell.codeFormatting.whitespaceAroundOperator": true,
     "powershell.codeFormatting.whitespaceAfterSeparator": true,
     "powershell.codeFormatting.ignoreOneLineBlock": false,
+    "powershell.codeFormatting.pipelineIndentationStyle": "IncreaseIndentationAfterEveryPipeline",
     "powershell.codeFormatting.preset": "Custom",
+    "powershell.codeFormatting.alignPropertyValuePairs": true,
     "files.trimTrailingWhitespace": true,
     "files.insertFinalNewline": true,
-    "powershell.scriptAnalysis.settingsPath": ".vscode\\analyzersettings.psd1"
+    "powershell.scriptAnalysis.settingsPath": ".vscode\\analyzersettings.psd1",
+    "powershell.scriptAnalysis.enable": true,
+    "files.associations": {
+        "*.ps1xml": "xml"
+    },
+    "cSpell.words": [
+        "COMPANYNAME",
+        "ICONURI",
+        "LICENSEURI",
+        "PROJECTURI",
+        "RELEASENOTES",
+        "buildhelpers",
+        "endregion",
+        "gitversion",
+        "icontains",
+        "keepachangelog",
+        "notin",
+        "pscmdlet",
+        "steppable"
+    ],
+    "[markdown]": {
+        "files.encoding": "utf8"
+    }
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,194 +1,16 @@
-# Versions
+# Change log for DFSDsc
 
-## Unreleased
+The format is based on and uses the types of changes according to [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## 4.4.0.0
+## [Unreleased]
 
-- Fix example publish to PowerShell Gallery by adding `gallery_api`
-  environment variable to `AppVeyor.yml` - fixes [Issue #91](https://github.com/PowerShell/DfsDsc/issues/91).
-- Fix minor style issues in statement case.
+### Changed
 
-## 4.3.0.0
-
-- Fixes PSSA style violation issues resulting - fixes [Issue #84](https://github.com/PowerShell/DfsDsc/issues/84).
-- Added 'DscResourcesToExport' to manifest to improve information in
-  PowerShell Gallery - fixes [Issue #86](https://github.com/PowerShell/DfsDsc/issues/86).
-- Set FunctionsToExport, CmdletsToExport, VariablesToExport, AliasesToExport
-  to empty list in manifest to meet best practice.
-- Explicitly removed extra hidden files from release package
-
-## 4.2.0.0
-
-- Add support for modifying staging quota size in
-  MSFT_DFSReplicationGroupMembership - fixes [Issue #77](https://github.com/PowerShell/DfsDsc/issues/77).
-- Refactored module folder structure to move resource to root folder of
-  repository and remove test harness - fixes [Issue #74](https://github.com/PowerShell/DfsDsc/issues/74).
-- Updated Examples to support deployment to PowerShell Gallery scripts.
-- Remove exclusion of all tags in appveyor.yml, so all common tests can be run
-  if opt-in.
-- Added .VSCode settings for applying DSC PSSA rules - fixes [Issue #75](https://github.com/PowerShell/DfsDsc/issues/75).
-- Updated LICENSE file to match the Microsoft Open Source Team
-  standard - fixes [Issue #79](https://github.com/PowerShell/DFSDsc/issues/79)
-
-## 4.1.0.0
-
-- Added Hub and Spoke replication group example - fixes [Issue #62](https://github.com/PowerShell/DFSDsc/issues/62).
-- Enabled PSSA rule violations to fail build - fixes [Issue #320](https://github.com/PowerShell/DFSDsc/issues/59).
-- Allow null values in resource group members or folders - fixes [Issue #27](https://github.com/PowerShell/xDFS/issues/27).
-- Added a CODE\_OF\_CONDUCT.md with the same content as in the README.md - fixes
-  [Issue #67](https://github.com/PowerShell/DFSDsc/issues/67).
-
-## 4.0.0.0
-
-- BREAKING CHANGE
-  - Renamed xDFS to DFSDsc - fixes [Issue #55](https://github.com/PowerShell/xDFS/issues/55).
-  - Changed all MSFT_xResourceName to MSFT_DFSResourceName.
-  - Updated DSCResources, Examples, Modules and Tests for new naming.
-  - Updated Year to 2018 in License and Manifest.
-  - Changed all Modules\DFSDsc\Examples\Resources to DFSResourceName.
-- Added the VS Code PowerShell extension formatting settings that cause PowerShell
-  files to be formatted as per the DSC Resource kit style guidelines.
-- Improve layout of badge area in README.MD.
-- Disabled MD013 rule checking to enable badge table.
-- Updated Year to 2017 in License and Manifest.
-- Added .github support files:
-  - CONTRIBUTING.md
-  - ISSUE_TEMPLATE.md
-  - PULL_REQUEST_TEMPLATE.md
-- Opted into Common Tests 'Validate Module Files' and 'Validate Script Files'.
-- Converted files with UTF8 with BOM over to UTF8 - fixes [Issue #47](https://github.com/PowerShell/xDFS/issues/47).
-- Added `Documentation and Examples` section to Readme.md file - see
-  [issue #49](https://github.com/PowerShell/xDFS/issues/49).
-- Prevent unit tests from DSCResource.Tests from running during test
-  execution - fixes [Issue #51](https://github.com/PowerShell/xDFS/issues/51).
-- Updated tests to meet Pester V4 guidelines - fixes [Issue #53](https://github.com/PowerShell/xDFS/issues/53).
-
-## 3.2.0.0
-
-- Converted AppVeyor.yml to pull Pester from PSGallery instead of Chocolatey.
-- Changed AppVeyor.yml to use default image.
-- Converted AppVeyor build process to use AppVeyor.psm1.
-- Resolved PSSA violations.
-- Resolved Readme.md style violations.
-- Converted Integration Tests to use Test Drive and stop using Invoke-Pester.
-- Move strings into separate language files.
-- Added CodeCov support.
-- Clean up manifest file by removing commented out sections.
-- Convert Examples to pass tests and meet minimum standards.
-- Convert to Wiki and auto-documentation generation.
-- Convert to TestHarness test execution method.
-- Correct parameter block format to meet guidelines.
-- Replaced all type accelerators with full type names.
-- Updated Readme.md to contain resource list.
-- Fixed xDFSNamespaceServerConfiguration by converting LocalHost to ComputerName
-  instead.
-- Added integration test to test for conflicts with other common resource kit modules.
-- Prevented ResourceHelper and Common module cmdlets from being exported to resolve
-  conflicts with other resource modules.
-
-## 3.1.0.0
-
-- MSFT_xDFSNamespaceServerConfiguration- resource added.
-- Corrected names of DFS Namespace sample files to indicate that they are setting
-  Namespace roots and folders.
-- Removed Pester version from AppVeyor.yml.
-
-## 3.0.0.0
-
-- RepGroup renamed to ReplicationGroup in all files.
-- xDFSReplicationGroupConnection- Changed DisableConnection parameter to EnsureEnabled.
-                                  Changed DisableRDC parameter to EnsureRDCEnabled.
-- xDFSReplicationGroup- Fixed bug where disabled connection was not enabled in
-  Fullmesh topology.
-
-## 2.2.0.0
-
-- DSC Module moved to MSFT.
-- MSFT_xDFSNamespace- Removed.
-
-## 2.1.0.0
-
-- MSFT_xDFSRepGroup- Fixed issue when using FQDN member names.
-- MSFT_xDFSRepGroupMembership- Fixed issue with Get-TargetResource when using
-  FQDN ComputerName.
-- MSFT_xDFSRepGroupConnection- Fixed issue with Get-TargetResource when using
-  FQDN SourceComputerName or FQDN DestinationComputerName.
-- MSFT_xDFSNamespaceRoot- Added write support to TimeToLiveSec parameter.
-- MSFT_xDFSNamespaceFolder- Added write support to TimeToLiveSec parameter.
-
-## 2.0.0.0
-
-- MSFT_xDFSNamespaceRoot- resource added.
-- MSFT_xDFSNamespaceFolder- resource added.
-- MSFT_xDFSNamespace- deprecated - use MSFT_xDFSNamespaceRoot instead.
-
-## 1.5.1.0
-
-- MSFT_xDFSNamespace- Add parameters:
-  - EnableSiteCosting
-  - EnableInsiteReferrals
-  - EnableAccessBasedEnumeration
-  - EnableRootScalability
-  - EnableTargetFailback
-  - ReferralPriorityClass
-  - ReferralPriorityRank
-
-## 1.5.0.0
-
-- MSFT_xDFSNamespace- New sample files added.
-- MSFT_xDFSNamespace- MOF parameter descriptions corrected.
-- MSFT_xDFSNamespace- Rearchitected code.
-- MSFT_xDFSNamespace- SMB Share is no longer removed when a namespace or target
-  is removed.
-- MSFT_xDFSNamespace- Removed SMB Share existence check.
-- Documentation layout corrected.
-- MSFT_xDFSRepGroup- Array Parameter output disabled in Get-TargetResource
-  until [this issue](https://windowsserver.uservoice.com/forums/301869-powershell/suggestions/11088807-get-dscconfiguration-fails-with-embedded-cim-type)
-  is resolved.
-
-## 1.4.2.0
-
-- MSFT_xDFSRepGroup- Fixed "Cannot bind argument to parameter 'DifferenceObject'
-  because it is null." error.
-- All Unit tests updated to use *_TestEnvironment functions in DSCResource.Tests\TestHelpers.psm1
-
-## 1.4.1.0
-
-- MSFT_xDFSNamespace- Renamed Sample_DcFSNamespace.ps1 to Sample_xDFSNamespace.
-- MSFT_xDFSNamespace- Corrected Import-DscResouce in example.
-
-## 1.4.0.0
-
-- Community update by Erik Granneman
-- New DSC recource xDFSNameSpace
-
-## 1.3.2.0
-
-- Documentation and Module Manifest Update only.
-
-## 1.3.1.0
-
-- xDFSRepGroupFolder- DfsnPath parameter added for setting DFS Namespace path mapping.
-
-## 1.3.0.0
-
-- xDFSRepGroup- If ContentPaths is set, PrimaryMember is set to first member in
-  the Members array.
-- xDFSRRepGroupMembership- PrimaryMembers property added so that Primary Member
-  can be set.
-
-## 1.2.1.0
-
-- xDFSRepGroup- Fix to ContentPaths generation when more than one folder is provided.
-
-## 1.2.0.0
-
-- xDFSRepGroup- ContentPaths string array parameter.
-
-## 1.1.0.0
-
-- xDFSRepGroupConnection- Resource added.
-
-## 1.0.0.0
-
-- Initial release.
+- BREAKING CHANGE: Changed resource prefix from MSFT to DSC.
+- Updated to use continuous delivery pattern using Azure DevOps - fixes
+  [Issue #41](https://github.com/dsccommunity/DFSDsc/issues/98).
+- Updated build badges in README.MD.
+- Renamed `DFSDsc.ResourceHelper` module to `DFSDsc.Common` to align to
+  other modules.
+- Correct case of localization folder names.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -0,0 +1,8 @@
+
+# Contributing
+
+Please check out common DSC Community [contributing guidelines](https://dsccommunity.org/guidelines/contributing).
+
+## Running the Tests
+
+If want to know how to run this module's tests you can look at the [Testing Guidelines](https://dsccommunity.org/guidelines/testing-guidelines/#running-tests)
diff --git a/GitVersion.yml b/GitVersion.yml
@@ -0,0 +1,26 @@
+mode: ContinuousDelivery
+next-version: 4.4.0
+major-version-bump-message: '\s?(breaking|major|breaking\schange)'
+minor-version-bump-message: '\s?(add|feature|minor)'
+patch-version-bump-message: '\s?(fix|patch)'
+no-bump-message: '\+semver:\s?(none|skip)'
+assembly-informational-format: '{NuGetVersionV2}+Sha.{Sha}.Date.{CommitDate}'
+branches:
+  master:
+    tag: preview
+  pull-request:
+    tag: PR
+  feature:
+    tag: useBranchName
+    increment: Minor
+    regex: f(eature(s)?)?[\/-]
+    source-branches: ['master']
+  hotfix:
+    tag: fix
+    increment: Patch
+    regex: (hot)?fix(es)?[\/-]
+    source-branches: ['master']
+
+ignore:
+  sha: []
+merge-message-formats: {}