BREAKING CHANGE; Update to new CD Pipeline - Fixes #98

[PlagueHO]

Pull Request (PR) description

This PR updates the repo to the new CD Pipeline structure.

This Pull Request (PR) fixes the following issues

• Fixes DFSDsc: Converting to new CI pipeline #98

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md in the resource folder.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me please when you have time?

Only 2 more repos (of mine) to go after this one ;)

---

This change is 

[johlju]

Reviewed 111 of 111 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @PlagueHO)

---

azure-pipelines.yml, line 7 at r1 (raw file):

- source/**/*

This need to be source/* now. Something broke in Azure DevOps and the docs that mentioned this pattern no longer exist, we had to change it all over. :/ Using ** will now make the pipeline to never run at all. This did work for about a week or two in ActiveDirectoryDsc. Now the docs read:

You may not include * in the middle of a path filter, and you may not use ?.

https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#wildcards

dsccommunity/ActiveDirectoryDsc#599

---

HISTORIC_CHANGELOG.md, line 1 at r1 (raw file):

# Historic change log for DFSDsc

Non-blocking: In a recent fix in Sampler this file is no longer needed. All the changelog can now be in CHANGELOG.md. This file was a workaround for a bug that is now fixed. :) But if you want to leave it as-is that is fine. :)

---

RequiredModules.psd1, line 14 at r1 (raw file):

'1.0.0'

Non-blocking: We can now use latest here. Sampler was fixed for this as well.

---

source/DFSDsc.psd1, line 66 at r1 (raw file):

            # A URL to the main website for this project.
            ProjectUri   = 'https://github.com/dsccommunity/DFSDsc'

Non-blocking: Do you want to add in the Icon url too?

---

source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.psm1, line 3 at r1 (raw file):

Import the Networking Common Modules

Maybe "...DFS Common module"?

[PlagueHO]

Awesome catches @johlju - didn't know about the other recent changes to the pipeline (been working on a large Azure architecture project long hours and no spare time). I'll repeat all the changes in the other repos today. I also found I hadn't updated the Examples with the correct info when I moved project over to dsccommunity. So fixed that too.

Reviewable status: 85 of 110 files reviewed, 2 unresolved discussions (waiting on @johlju and @PlagueHO)

---

azure-pipelines.yml, line 7 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

- source/**/*

This need to be source/* now. Something broke in Azure DevOps and the docs that mentioned this pattern no longer exist, we had to change it all over. :/ Using ** will now make the pipeline to never run at all. This did work for about a week or two in ActiveDirectoryDsc. Now the docs read:

You may not include * in the middle of a path filter, and you may not use ?.

https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#wildcards

dsccommunity/ActiveDirectoryDsc#599

Ah right OK. I'll need to go through and modify all my repos :) Might tag you in the PR's 😁

---

HISTORIC_CHANGELOG.md, line 1 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

# Historic change log for DFSDsc

Non-blocking: In a recent fix in Sampler this file is no longer needed. All the changelog can now be in CHANGELOG.md. This file was a workaround for a bug that is now fixed. :) But if you want to leave it as-is that is fine. :)

I'll merge them - will go through and do all the others as well ;) Expect PR's 😁

[PlagueHO]

Reviewable status: 78 of 110 files reviewed, 2 unresolved discussions (waiting on @johlju)

---

source/DSCResources/DSC_DFSReplicationGroupMembership/DSC_DFSReplicationGroupMembership.psm1, line 3 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Import the Networking Common Modules

Maybe "...DFS Common module"?

Done.

[johlju]

Reviewed 33 of 33 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[johlju]

I hope the big project is working out well. :) Awesome work with all the PR's! All reviewed. 😄

[PlagueHO]

Thanks for all the reviews @johlju - we'll see how project is working out in the next few days ;)