Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource IEEnhancedSecurityConfiguration #300

Closed
wants to merge 5 commits into from

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 28, 2020

Pull Request (PR) description

This moves the resource xIEEsc from module xSystemSecurity and renames it to IEEnhancedSecurityConfiguration.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju requested a review from PlagueHO January 28, 2020 07:17
@johlju johlju added the needs review The pull request needs a code review. label Jan 28, 2020
@PlagueHO
Copy link
Member

Sweet! @johlju - I'll trade you: Can you review this one for me? It would be good to get this in after I complete the move to the new CI pipeline. #299

@johlju
Copy link
Member Author

johlju commented Jan 29, 2020

Yep, better to get thios one in after the module is converted.

@PlagueHO PlagueHO closed this Jan 31, 2020
@johlju
Copy link
Member Author

johlju commented Feb 1, 2020

@PlagueHO You could have re-targeted this PR against master instead of closing (where you edit the PR title). I open a new one since I can't re-open this one.

@PlagueHO
Copy link
Member

PlagueHO commented Feb 1, 2020

I didn't actually close it - it closed automatically when the dev branch was deleted 😢

@PlagueHO
Copy link
Member

PlagueHO commented Feb 1, 2020

Which is why I don't have a "reopen" button:
image

😁

@johlju
Copy link
Member Author

johlju commented Feb 1, 2020

Yep, need to re-target all PR's before removing the dev branch. 🙂 It's in the "Steps" 😉

@johlju
Copy link
Member Author

johlju commented Feb 1, 2020

No worries. But sad for those other PR's that might have been open, they won't know why it was closed. :/

@PlagueHO
Copy link
Member

PlagueHO commented Feb 1, 2020

I'll go through and comment on them. I've already commented on the ones that weren't flagged as abandoned.

@PlagueHO
Copy link
Member

PlagueHO commented Feb 1, 2020

Doh! Must have missed that step - I think I forgot where I was in the process a few times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants