BREAKING CHANGE: Update Module to Continuous Delivery - Fixes #295 #299
Conversation
|
@johlju - would you mind reviewing this one for me? |
|
I will. Later this week. 🙂 |
There was a problem hiding this comment.
Reviewed 175 of 175 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
.vscode/settings.json, line 4 at r1 (raw file):
false,
Should this be true? see next comment
tests/Integration/ComputerManagementDsc.Common.Tests.ps1, line 9 at r1 (raw file):
{ $false
Thing the vscode settings are wrong?
There was a problem hiding this comment.
Reviewable status: 146 of 175 files reviewed, all discussions resolved (waiting on @johlju)
.vscode/settings.json, line 4 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
false,Should this be true? see next comment
I fixed this - copied from SqlServerDsc. I also applied auto formatting to all test files and also found some other issues and fixed. So could you review again @johlju - sorry about that!
There was a problem hiding this comment.
Hi @johlju - I corrected a bunch of formatting.
Reviewable status: 146 of 175 files reviewed, all discussions resolved (waiting on @johlju)
There was a problem hiding this comment.
Reviewed 29 of 29 files at r2.
Reviewable status:
|
@PlagueHO looks good! Soon one more converted! |
johlju
added
ready for merge
Pull Request (PR) description
This PR updates the pipeline to the new Continuous Delivery structure. It also fixes WindowsCapability issues.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is