Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: ScheduledTask - remove parameters that are not key or required - Fixes #249 #252

Merged
merged 17 commits into from
Aug 24, 2019

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Aug 24, 2019

Pull Request (PR) description

In preparation for fixing issue #247 and adding the latest version of Test-DscParameterState to from NetworkingDsc to support ordered array testing it identified various issues with ScheduledTask that needed to be fixed. This PR fixes those issues as well as refactoring to improve the structure.

  • BREAKING CHANGE: ScheduledTask:
    • Correct output type of DaysInterval parameter from Get-TargetResource to
      match MOF.
    • Correct output type of StartTime parameter from Get-TargetResource to
      match MOF.
    • Refactored Get-TargetResource to remove parameters that
      are not key or required - fixes Issue #249.
    • Added function Test-DateStringContainsTimeZone to determine if a string
      containing a date time includes a time zone.
  • Updated common function Test-DscParameterState to support ordered comparison
    of arrays by copying function and tests from NetworkingDsc - fixes Issue #250.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing this when you have a moment?


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #252 into dev will increase coverage by <1%.
The diff coverage is 91%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #252    +/-   ##
====================================
+ Coverage    87%    88%   +<1%     
====================================
  Files        12     12            
  Lines      1345   1398    +53     
====================================
+ Hits       1176   1231    +55     
+ Misses      169    167     -2

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Aug 24, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Could not find any issue with this. 🙂

Reviewed 8 of 8 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit be97aa6 into dsccommunity:dev Aug 24, 2019
@PlagueHO PlagueHO deleted the Issue-247 branch August 24, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
3 participants