-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: ScheduledTask - remove parameters that are not key or required - Fixes #249 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #252 +/- ##
====================================
+ Coverage 87% 88% +<1%
====================================
Files 12 12
Lines 1345 1398 +53
====================================
+ Hits 1176 1231 +55
+ Misses 169 167 -2 |
johlju
reviewed
Aug 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not find any issue with this. 🙂
Reviewed 8 of 8 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In preparation for fixing issue #247 and adding the latest version of
Test-DscParameterState
to from NetworkingDsc to support ordered array testing it identified various issues with ScheduledTask that needed to be fixed. This PR fixes those issues as well as refactoring to improve the structure.DaysInterval
parameter fromGet-TargetResource
tomatch MOF.
StartTime
parameter fromGet-TargetResource
tomatch MOF.
Get-TargetResource
to remove parameters thatare not key or required - fixes Issue #249.
Test-DateStringContainsTimeZone
to determine if a stringcontaining a date time includes a time zone.
Test-DscParameterState
to support ordered comparisonof arrays by copying function and tests from
NetworkingDsc
- fixes Issue #250.This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
@johlju - would you mind reviewing this when you have a moment?
This change is