Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScheduledTask: Refactor to Remove non-Required/Key parameters from Get-TargetResource #249

Closed
PlagueHO opened this issue Aug 24, 2019 · 0 comments · Fixed by #252
Closed

ScheduledTask: Refactor to Remove non-Required/Key parameters from Get-TargetResource #249

PlagueHO opened this issue Aug 24, 2019 · 0 comments · Fixed by #252
Assignees
@PlagueHO
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Aug 24, 2019 •
edited
Loading

Get-TargetResource accepts many parameters that are not key/required. We should refactor Get-TargetResource so it does not accept these parameters.

To do this, we should move all the code from Get-TargetResource into a new function Get-CurrentResource that accepts all values and change all functions (including Get-TargetResource) to call this.

This should be considered a BREAKING CHANGE.
@PlagueHO PlagueHO added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Aug 24, 2019
@PlagueHO PlagueHO self-assigned this Aug 24, 2019
@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Aug 24, 2019
@PlagueHO PlagueHO mentioned this issue Aug 24, 2019
Merged
9 tasks
PlagueHO added a commit that referenced this issue Aug 24, 2019
@PlagueHO
Merge pull request #252 from PlagueHO/Issue-247
be97aa6 
BREAKING CHANGE: ScheduledTask - remove parameters that are not key or required - Fixes #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
1 participant
@PlagueHO