Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADReplicationSiteLink: Fix When ensure absent test-targetresource return false if other parameters are set. #594

Merged
merged 6 commits into from
Apr 25, 2020
Merged

ADReplicationSiteLink: Fix When ensure absent test-targetresource return false if other parameters are set. #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0dd5c84
Fix MSFT_ADReplicationSiteLink.psm1 -Ensure Absent
wmaniek123 Apr 15, 2020
e27f7b7
Merge branch 'master' into patch-1
X-Guardian Apr 16, 2020
4e1f52c
Merge branch 'master' into patch-1
X-Guardian Apr 19, 2020
0357af1
Update CHANGELOG.md
wmaniek123 Apr 21, 2020
ebcb2f1
Merge branch 'master' into patch-1
X-Guardian Apr 24, 2020
c6fe2c0
Merge branch 'master' into patch-1
X-Guardian Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
- ADUser
- Fixed PasswordAuthentication parameter handling
([issue #582](https://github.com/dsccommunity/ActiveDirectoryDsc/issues/582)).
- ADReplicationSiteLink
- Fix Test-TargetResource when Ensure is Absent and other attributes are set
([issue #593](https://github.com/PowerShell/ActiveDirectoryDsc/issues/593)).

### Fixed

### Changed

Expand Down
4 changes: 4 additions & 0 deletions source/DSCResources/MSFT_ADReplicationSiteLink/MSFT_ADReplicationSiteLink.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,10 @@ function Test-TargetResource
{
return $false
}
elseif ($Ensure -eq 'Absent')
{
return $true
}

# Test for SitesIncluded.
foreach ($desiredIncludedSite in $SitesIncluded)
Expand Down