-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADReplicationSiteLink: Fix When ensure absent test-targetresource return false if other parameters are set. #594
Conversation
Fix MSFT_ADReplicationSiteLink.psm1 test-targetresource when ensure is absent and other attributes are sent.
Hi @wmaniek123, this PR is failing because you haven't added an entry to the CHANGELOG.md file. Add the following under the ## [Unreleased] line:
|
Hi @X-Guardian. CHANGELOG.md file has been updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved
Thanks for this @wmaniek123 |
Pull Request (PR) description
Fix ADReplicationSiteLink
Test-TargetResource
whenEnsure
isAbsent
and other attributes are set.This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is