Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADReplicationSiteLink: Fix When ensure absent test-targetresource return false if other parameters are set. #594

Merged
merged 6 commits into from
Apr 25, 2020

Conversation

wmaniek123
Copy link
Contributor

@wmaniek123 wmaniek123 commented Apr 15, 2020

Pull Request (PR) description

Fix ADReplicationSiteLink Test-TargetResource when Ensure is Absent and other attributes are set.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

wmaniek123 and others added 2 commits April 16, 2020 01:21
Fix MSFT_ADReplicationSiteLink.psm1  test-targetresource when ensure is absent and other attributes are sent.
@X-Guardian
Copy link
Contributor

Hi @wmaniek123, this PR is failing because you haven't added an entry to the CHANGELOG.md file.

Add the following under the ## [Unreleased] line:

### Fixed

- ADReplicationSiteLink
  - Fix Test-TargetResource when Ensure is Absent and other attributes are set
    ([issue #593](https://github.com/PowerShell/ActiveDirectoryDsc/issues/593)).

@X-Guardian X-Guardian added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Apr 16, 2020
@wmaniek123
Copy link
Contributor Author

Hi @X-Guardian. CHANGELOG.md file has been updated now

@X-Guardian X-Guardian added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Apr 24, 2020
Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, 1 of 1 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@X-Guardian X-Guardian added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Apr 25, 2020
Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@X-Guardian
Copy link
Contributor

Thanks for this @wmaniek123

@X-Guardian X-Guardian merged commit debb0da into dsccommunity:master Apr 25, 2020
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADReplicationSiteLink: When ensure absent test-targetresource return false if other parameters are set.
3 participants