ADReplicationSubnet: Add Integration Testing, Add Description #507

1800Zeta · 2019-09-19T09:29:32Z

Pull Request (PR) description

Adds integration testing ability. Adds the Description field to Subnets

This Pull Request (PR) fixes the following issues

Task list

This change is

Unit tests also added

Tests for add, remove, rename default sites. Restores at the end back to default settings.

increase codecov score

Adding integration tests to Replication subnet before adding description

Small update to tests

Includes Integration tests and unit tests

Also had to tweak unit tests for updated logic

Re-add to unreleased section

codecov-io · 2019-09-21T07:25:38Z

Codecov Report

Merging #507 into dev will increase coverage by <1%.
The diff coverage is 93%.

@@         Coverage Diff          @@
##            dev   #507    +/-   ##
====================================
+ Coverage    98%    98%   +<1%     
====================================
  Files        23     23            
  Lines      3108   3114     +6     
  Branches     10     10            
====================================
+ Hits       3063   3070     +7     
+ Misses       35     34     -1     
  Partials     10     10

Post merge update

johlju

Awesome work! I will test the integration tests manually tomorrow too.

Reviewed 4 of 8 files at r6, 3 of 3 files at r9.
Reviewable status: 7 of 9 files reviewed, 4 unresolved discussions (waiting on @1800Zeta)

DSCResources/MSFT_ADReplicationSubnet/en-US/MSFT_ADReplicationSubnet.strings.psd1, line 8 at r9 (raw file):

SetReplicationSubnetDescription    = Set the replication subnet '{0}' description to '{1}'.

Add this string key to the bottom of the list and add the id (ADRS0010) to the string.

Tests/Unit/MSFT_ADReplicationSubnet.Tests.ps1, line 95 at r9 (raw file):

should

Should (upper-case 'S')

Tests/Unit/MSFT_ADReplicationSubnet.Tests.ps1, line 188 at r9 (raw file):

It 'Should return false for wrong Description' {

Can we also test that it returns true when the descriptions are equal?

Tests/Unit/MSFT_ADReplicationSubnet.Tests.ps1, line 315 at r9 (raw file):

fail

Maybe we shouldn't use the word fail here unless we testing it to fail?

1800Zeta

Reviewable status: 7 of 9 files reviewed, 4 unresolved discussions (waiting on @johlju)

DSCResources/MSFT_ADReplicationSubnet/en-US/MSFT_ADReplicationSubnet.strings.psd1, line 8 at r9 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

SetReplicationSubnetDescription    = Set the replication subnet '{0}' description to '{1}'.
Add this string key to the bottom of the list and add the id (ADRS0010) to the string.

Done.

Tests/Unit/MSFT_ADReplicationSubnet.Tests.ps1, line 95 at r9 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

should
Should (upper-case 'S')

Done.

Tests/Unit/MSFT_ADReplicationSubnet.Tests.ps1, line 188 at r9 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

It 'Should return false for wrong Description' {
Can we also test that it returns true when the descriptions are equal?

Done.

Tests/Unit/MSFT_ADReplicationSubnet.Tests.ps1, line 315 at r9 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

fail
Maybe we shouldn't use the word fail here unless we testing it to fail?

Done.

johlju

Reviewed 2 of 8 files at r6, 2 of 2 files at r10.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @1800Zeta)

Tests/Integration/MSFT_ADReplicationSubnet.Integration.Tests.ps1, line 37 at r9 (raw file):

        }

        $configurationName = "$($script:dscResourceName)_CreateSubnet_Config"

Getting this error. I think we need to add the Site that is used for testing as a prerequisites test and then make a cleanup test at the bottom that removes the site? 🤔 What do you think?

Executing script .\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1

  Describing MSFT_ADReplicationSubnet_Integration

    Context When using configuration MSFT_ADReplicationSubnet_CreateSubnet_Config
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADReplicationSubnet\MSFT_ADReplicationSubnet.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Resource ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]: LCM:  [ Start  Test     ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Getting replication subnet '10.0.0.0/24'. (ADRS0003)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Replication subnet '10.0.0.0/24' is absent. (ADRS0006)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] The replication subnet '10.0.0.0/24' is not in the desired state. (ADRS0009)
VERBOSE: [DC01]: LCM:  [ End    Test     ]  [[ADReplicationSubnet]LondonSubnet]  in 0.2190 seconds.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Create the replication subnet '10.0.0.0/24'. (ADRS0001)
      [-] Should compile and apply the MOF without throwing 1.68s
        Expected no exception to be thrown, but an exception "Identity info provided in the extended attribute: 'Site' could not be resolved. Reason: 'Cannot find an object with identity: 'London' under: 'CN=Sites,CN=Configuration,DC=contoso,DC=com'.'." was thrown from C:\sou
rce\ActiveDirectoryDsc\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1:59 char:21
            + ...               Start-DscConfiguration @startDscConfigurationParameters
            +                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
        60:                 } | Should -Not -Throw
        at <ScriptBlock>, C:\source\ActiveDirectoryDsc\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1: line 41
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
WARNING: [DC01]:                            [] The GET operation will be carried against a pending configuration since the latest configuration has not converged yet.
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADReplicationSubnet\MSFT_ADReplicationSubnet.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Get      ]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Getting replication subnet '10.0.0.0/24'. (ADRS0003)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Replication subnet '10.0.0.0/24' is absent. (ADRS0006)
VERBOSE: [DC01]: LCM:  [ End    Get      ]  [[ADReplicationSubnet]LondonSubnet]  in 0.2820 seconds.
VERBOSE: [DC01]: LCM:  [ End    Get      ]    in  0.7200 seconds.
      [+] Should be able to call Get-DscConfiguration without throwing 1.24s
      [+] Should have set the resource and all the parameters should match 7ms
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = TestConfiguration,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
VERBOSE: [DC01]: LCM:  [ Start  Test     ]
WARNING: [DC01]:                            [] The TEST operation will be carried against a pending configuration since the latest configuration has not converged yet.
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADReplicationSubnet\MSFT_ADReplicationSubnet.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Resource ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]: LCM:  [ Start  Test     ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Getting replication subnet '10.0.0.0/24'. (ADRS0003)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Replication subnet '10.0.0.0/24' is absent. (ADRS0006)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] The replication subnet '10.0.0.0/24' is not in the desired state. (ADRS0009)
VERBOSE: [DC01]: LCM:  [ End    Test     ]  [[ADReplicationSubnet]LondonSubnet] False in 0.2970 seconds.
VERBOSE: [DC01]: LCM:  [ End    Resource ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]: LCM:  [ End    Test     ]     Completed processing test operation. The operation returned False.
VERBOSE: [DC01]: LCM:  [ End    Test     ]    in  0.7030 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 1.681 seconds
      [-] Should return $true when Test-DscConfiguration is run 1.76s
        Expected strings to be the same, but they were different.
        Expected length: 4
        Actual length:   5
        Strings differ at index 0.
        Expected: 'True'
        But was:  'False'
        82:                 Test-DscConfiguration -Verbose | Should -Be 'True'
        at <ScriptBlock>, C:\source\ActiveDirectoryDsc\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1: line 82

1800Zeta

Reviewable status: 7 of 9 files reviewed, 1 unresolved discussion (waiting on @johlju)

Tests/Integration/MSFT_ADReplicationSubnet.Integration.Tests.ps1, line 37 at r9 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Getting this error. I think we need to add the Site that is used for testing as a prerequisites test and then make a cleanup test at the bottom that removes the site? 🤔 What do you think?

Executing script .\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1

  Describing MSFT_ADReplicationSubnet_Integration

    Context When using configuration MSFT_ADReplicationSubnet_CreateSubnet_Config
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADReplicationSubnet\MSFT_ADReplicationSubnet.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Resource ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]: LCM:  [ Start  Test     ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Getting replication subnet '10.0.0.0/24'. (ADRS0003)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Replication subnet '10.0.0.0/24' is absent. (ADRS0006)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] The replication subnet '10.0.0.0/24' is not in the desired state. (ADRS0009)
VERBOSE: [DC01]: LCM:  [ End    Test     ]  [[ADReplicationSubnet]LondonSubnet]  in 0.2190 seconds.
VERBOSE: [DC01]: LCM:  [ Start  Set      ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Create the replication subnet '10.0.0.0/24'. (ADRS0001)
      [-] Should compile and apply the MOF without throwing 1.68s
        Expected no exception to be thrown, but an exception "Identity info provided in the extended attribute: 'Site' could not be resolved. Reason: 'Cannot find an object with identity: 'London' under: 'CN=Sites,CN=Configuration,DC=contoso,DC=com'.'." was thrown from C:\sou
rce\ActiveDirectoryDsc\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1:59 char:21
            + ...               Start-DscConfiguration @startDscConfigurationParameters
            +                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
        60:                 } | Should -Not -Throw
        at <ScriptBlock>, C:\source\ActiveDirectoryDsc\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1: line 41
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
WARNING: [DC01]:                            [] The GET operation will be carried against a pending configuration since the latest configuration has not converged yet.
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADReplicationSubnet\MSFT_ADReplicationSubnet.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Get      ]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Getting replication subnet '10.0.0.0/24'. (ADRS0003)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Replication subnet '10.0.0.0/24' is absent. (ADRS0006)
VERBOSE: [DC01]: LCM:  [ End    Get      ]  [[ADReplicationSubnet]LondonSubnet]  in 0.2820 seconds.
VERBOSE: [DC01]: LCM:  [ End    Get      ]    in  0.7200 seconds.
      [+] Should be able to call Get-DscConfiguration without throwing 1.24s
      [+] Should have set the resource and all the parameters should match 7ms
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = TestConfiguration,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer DC01 with user sid S-1-5-21-530133819-3181352061-503517500-500.
VERBOSE: [DC01]: LCM:  [ Start  Test     ]
WARNING: [DC01]:                            [] The TEST operation will be carried against a pending configuration since the latest configuration has not converged yet.
VERBOSE: [DC01]:                            [DSCEngine] Importing the module C:\source\ActiveDirectoryDsc\DscResources\MSFT_ADReplicationSubnet\MSFT_ADReplicationSubnet.psm1 in force mode.
VERBOSE: [DC01]: LCM:  [ Start  Resource ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]: LCM:  [ Start  Test     ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Importing the module MSFT_ADReplicationSubnet in force mode.
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Getting replication subnet '10.0.0.0/24'. (ADRS0003)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] Replication subnet '10.0.0.0/24' is absent. (ADRS0006)
VERBOSE: [DC01]:                            [[ADReplicationSubnet]LondonSubnet] The replication subnet '10.0.0.0/24' is not in the desired state. (ADRS0009)
VERBOSE: [DC01]: LCM:  [ End    Test     ]  [[ADReplicationSubnet]LondonSubnet] False in 0.2970 seconds.
VERBOSE: [DC01]: LCM:  [ End    Resource ]  [[ADReplicationSubnet]LondonSubnet]
VERBOSE: [DC01]: LCM:  [ End    Test     ]     Completed processing test operation. The operation returned False.
VERBOSE: [DC01]: LCM:  [ End    Test     ]    in  0.7030 seconds.
VERBOSE: Operation 'Invoke CimMethod' complete.
VERBOSE: Time taken for configuration job to complete is 1.681 seconds
      [-] Should return $true when Test-DscConfiguration is run 1.76s
        Expected strings to be the same, but they were different.
        Expected length: 4
        Actual length:   5
        Strings differ at index 0.
        Expected: 'True'
        But was:  'False'
        82:                 Test-DscConfiguration -Verbose | Should -Be 'True'
        at <ScriptBlock>, C:\source\ActiveDirectoryDsc\Tests\Integration\MSFT_ADReplicationSubnet.Integration.Tests.ps1: line 82

Done. Also realised that it should be [[ADReplicationSubnet]Integration_Test] so have fixed that now and all good.

johlju

Reviewed 2 of 2 files at r11.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @1800Zeta)

Tests/Integration/MSFT_ADReplicationSubnet.config.ps1, line 151 at r11 (raw file):

Creates a site as part of prerequisits

Wrong description here. :)

johlju · 2019-09-25T18:43:16Z

Awesome work on this! 😃 Just one more small comment then this is ready to merge I think. 🙂

1800Zeta · 2019-09-25T18:51:29Z

Thank you @johlju I've updated the line :)

1800Zeta

Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @johlju)

Tests/Integration/MSFT_ADReplicationSubnet.config.ps1, line 151 at r11 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Creates a site as part of prerequisits
Wrong description here. :)

Done.

johlju

Reviewed 1 of 1 files at r12.
Reviewable status: complete! all files reviewed, all discussions resolved

1800Zeta and others added 19 commits September 12, 2019 13:50

Checking in to switch dev machines

419c4a4

Add description attribute to test-resource with unit tests

8dc90e7

Add Description to Set-TargetResource

e4b255d

Unit tests also added

Update test to increase codecov

dbb48d0

Added Integration Testing

de1cbba

Tests for add, remove, rename default sites. Restores at the end back to default settings.

Update Help Text and a small tidy up

f1fd66d

Update CHANGELOG.md

55b0c3d

Update MSFT_ADReplicationSite.Tests.ps1

ee8dbe9

increase codecov score

Updates based on review

07933f2

Set RenameDefaultFirstSiteName to false by default

823a1c5

Add Integration Tests

915f6cc

Adding integration tests to Replication subnet before adding description

Update MSFT_ADReplicationSubnet.config.ps1

72ed5ad

Small update to tests

Adding Description to ADReplicationSubnet

bd998a4

Includes Integration tests and unit tests

Update changelog and example

6c4e355

Update CHANGELOG.md

ff0629a

Feedback request Pt2

bc5dd69

Also had to tweak unit tests for updated logic

Remove extra parentheses as requested

83b8971

Merge branch 'dev' into dev

9daa430

Merge branch 'dev' into ADReplicationSubnet

dca6684

1800Zeta closed this Sep 19, 2019

1800Zeta added 3 commits September 20, 2019 18:05

Update CHANGELOG.md

0f38b6c

Re-add to unreleased section

Update CHANGELOG.md

36acb70

Blank Line under Unreleased header

2823f32

1800Zeta reopened this Sep 20, 2019

jouzu-mark and others added 2 commits September 21, 2019 08:12

Merge branch 'dev' into ADReplicationSubnet

458047e

Merge branch 'dev' into ADReplicationSubnet

c57fde7

johlju removed the updated by author The pull request was last updated by the author. label Sep 21, 2019

1800Zeta and others added 2 commits September 21, 2019 11:42

Merge branch 'dev' into ADReplicationSubnet

db55c92

Update CHANGELOG.md

08c87db

Post merge update

1800Zeta marked this pull request as ready for review September 23, 2019 06:25

1800Zeta added 4 commits September 23, 2019 10:32

Additional test to ensure empty location string changes to $null

5ccb798

Update about_ADReplicationSubnet.help.txt

7db45ad

Merge remote-tracking branch 'upstream/dev' into dev

c1dcfec

Merge branch 'dev' into ADReplicationSubnet

0aa4351

johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Sep 24, 2019

johlju requested changes Sep 24, 2019

View reviewed changes

johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Sep 24, 2019

Feedback update

cd28bd6

1800Zeta commented Sep 25, 2019

View reviewed changes

johlju requested changes Sep 25, 2019

View reviewed changes

Added Pre-Req Config. Changed name of config to Integration_Test

ed1a23a

1800Zeta commented Sep 25, 2019

View reviewed changes

johlju requested changes Sep 25, 2019

View reviewed changes

Update MSFT_ADReplicationSubnet.config.ps1

4546d43

1800Zeta commented Sep 25, 2019

View reviewed changes

johlju approved these changes Sep 25, 2019

View reviewed changes

johlju changed the title ~~ADReplicationSubnet Add Integration Testing, Add Description~~ ADReplicationSubnet: Add Integration Testing, Add Description Sep 25, 2019

johlju merged commit 3e96da3 into dsccommunity:dev Sep 25, 2019

johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Sep 25, 2019

1800Zeta deleted the ADReplicationSubnet branch October 15, 2019 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADReplicationSubnet: Add Integration Testing, Add Description #507

ADReplicationSubnet: Add Integration Testing, Add Description #507

1800Zeta commented Sep 19, 2019 •

edited

Loading

codecov-io commented Sep 21, 2019 •

edited

Loading

johlju left a comment

1800Zeta left a comment

johlju left a comment

1800Zeta left a comment

johlju left a comment

johlju commented Sep 25, 2019

1800Zeta commented Sep 25, 2019

1800Zeta left a comment

johlju left a comment

ADReplicationSubnet: Add Integration Testing, Add Description #507

ADReplicationSubnet: Add Integration Testing, Add Description #507

Conversation

1800Zeta commented Sep 19, 2019 • edited Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

codecov-io commented Sep 21, 2019 • edited Loading

Codecov Report

johlju left a comment

Choose a reason for hiding this comment

1800Zeta left a comment

Choose a reason for hiding this comment

johlju left a comment

Choose a reason for hiding this comment

1800Zeta left a comment

Choose a reason for hiding this comment

johlju left a comment

Choose a reason for hiding this comment

johlju commented Sep 25, 2019

1800Zeta commented Sep 25, 2019

1800Zeta left a comment

Choose a reason for hiding this comment

johlju left a comment

Choose a reason for hiding this comment

1800Zeta commented Sep 19, 2019 •

edited

Loading

codecov-io commented Sep 21, 2019 •

edited

Loading