Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADReplicationSubnet: Add description field #503

Closed
1800Zeta opened this issue Sep 16, 2019 · 1 comment · Fixed by #507
Closed

ADReplicationSubnet: Add description field #503

1800Zeta opened this issue Sep 16, 2019 · 1 comment · Fixed by #507
Labels
enhancement The issue is an enhancement request.

Comments

@1800Zeta
Copy link
Contributor

Add the ability to set the description of the Replication Subnet via DSC. This is an additional parameter/attribute to the existing solution
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Sep 16, 2019
@1800Zeta
Copy link
Contributor Author

Have already done work on this and the integration tests, once my PR is completed, will submit a new PR with the changes

This was referenced Sep 18, 2019
Closed
Merged
johlju pushed a commit that referenced this issue Sep 25, 2019
@1800Zeta @johlju
ADReplicationSubnet: Add Integration Testing, Add Description (#507)
3e96da3 
- Changes to ADReplicationSubnet
  - Added 'Description' attribute parameter (issue #503)
  - Added Integration testing (issue #357)
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ADReplicationSubnet: Add Integration Testing, Add Description
2 participants
@johlju @1800Zeta