Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveDIrectoryDsc: Updated to optimize module auto-discovery #470

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 5, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Partly #463

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

johlju added 2 commits August 5, 2019 13:40
- Module manifest has been updated to optimize module auto-discovery (issue dsccommunity#463).
@johlju johlju changed the title Fix issue 463 ActiveDIrectoryDsc: Updated to optimize module auto-discovery Aug 5, 2019
@johlju johlju added the needs review The pull request needs a code review. label Aug 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #470 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #470   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        20     20           
  Lines      2815   2815           
  Branches     10     10           
===================================
  Hits       2766   2766           
  Misses       39     39           
  Partials     10     10

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 1c2ce11 into dsccommunity:dev Aug 5, 2019
@johlju johlju deleted the fix-issue-463 branch August 5, 2019 16:56
@johlju johlju removed the needs review The pull request needs a code review. label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants