ActiveDirectoryDsc: Update module manifest #463
Labels
enhancement
The issue is an enhancement request.
good first issue
The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
high priority
The issue or PR should be resolved first. It is of less priority than the label 'Blocking Release'.
Comments
johlju
added
enhancement
|
An entry in the pull request template should be added as well, so there are a reminder to add new resource to the module manifest. |
johlju
added
in progress
johlju
added a commit
to johlju/ActiveDirectoryDsc
that referenced
this issue
Aug 5, 2019
|
This is also documented in the article PowerShell module authoring considerations. |
johlju
added a commit
to johlju/ActiveDirectoryDsc
that referenced
this issue
Aug 5, 2019
- Module manifest has been updated to optimize module auto-discovery (issue dsccommunity#463).
10 tasks
johlju
added a commit
that referenced
this issue
Aug 5, 2019
- Changes to ActiveDirectoryDsc - Module manifest has been updated to optimize module auto-discovery (issue #463).
|
I discussed offline with @PlagueHO regatrding exporting of the resources, and he thinks it was because of an edge case the resource was exported, but since we are not sure what the benefit is (or downside) lets leave it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To optimize the loading of the resource we should make sure we use the same pattern as in the manifest of ActiveDIrectoryCDDsc https://github.com/PowerShell/ActiveDirectoryCSDsc/blob/dev/ActiveDirectoryCSDsc.psd1.
There are some properties that need still be set to
@()that is not part of our manifest, also make sure to export the resources (which will improve how the resource will look in PowerShell Gallery).The text was updated successfully, but these errors were encountered: