Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PSAvoidUsingConvertToSecureStringWithPlainText #436

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 17, 2019

Pull Request (PR) description

  • Changes to xActiveDirectory
    • Removed unnecessary Script Analyzer rule overrides from tests.

This Pull Request (PR) fixes the following issues

n/a

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jul 17, 2019
@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #436 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #436   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        20     20           
  Lines      2705   2705           
  Branches     10     10           
===================================
  Hits       2608   2608           
  Misses       87     87           
  Partials     10     10

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 12 files at r1, 1 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 6cc03a6 into dsccommunity:dev Jul 18, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Jul 18, 2019
@johlju johlju deleted the remove-PSAvoidUsingConvertToSecureStringWithPlainText branch July 18, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants