Remove PSAvoidUsingConvertToSecureStringWithPlainText (#436)

- Changes to xActiveDirectory - Removed unnecessary Script Analyzer rule overrides from tests.
dsccommunity · Jul 18, 2019 · 6cc03a6 · 6cc03a6
1 parent ca9fdbe
commit 6cc03a6
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 28 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -33,6 +33,7 @@
     - New-CimCredentialInstance
     - Add-TypeAssembly
     - New-ADDirectoryContext
+  - Removed unnecessary Script Analyzer rule overrides from tests.
 - Changes to xADManagedServiceAccount
   - Added a requirement to README stating "Group Managed Service Accounts
     need at least one Windows Server 2012 Domain Controller"

diff --git a/Tests/Unit/MSFT_xADComputer.Tests.ps1 b/Tests/Unit/MSFT_xADComputer.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param ()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADComputer'
 

diff --git a/Tests/Unit/MSFT_xADDomain.Tests.ps1 b/Tests/Unit/MSFT_xADDomain.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADDomain'
 

diff --git a/Tests/Unit/MSFT_xADDomainDefaultPasswordPolicy.Tests.ps1 b/Tests/Unit/MSFT_xADDomainDefaultPasswordPolicy.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADDomainDefaultPasswordPolicy'
 

diff --git a/Tests/Unit/MSFT_xADDomainTrust.Tests.ps1 b/Tests/Unit/MSFT_xADDomainTrust.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param ()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADDomainTrust'
 

diff --git a/Tests/Unit/MSFT_xADGroup.Tests.ps1 b/Tests/Unit/MSFT_xADGroup.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADGroup'
 

diff --git a/Tests/Unit/MSFT_xADKDSKey.Tests.ps1 b/Tests/Unit/MSFT_xADKDSKey.Tests.ps1
@@ -1,5 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADKDSKey'
 

diff --git a/Tests/Unit/MSFT_xADManagedServiceAccount.Tests.ps1 b/Tests/Unit/MSFT_xADManagedServiceAccount.Tests.ps1
@@ -1,5 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADManagedServiceAccount'
 

diff --git a/Tests/Unit/MSFT_xADObjectEnabledState.Tests.ps1 b/Tests/Unit/MSFT_xADObjectEnabledState.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADObjectEnabledState'
 

diff --git a/Tests/Unit/MSFT_xADOrganizationalUnit.Tests.ps1 b/Tests/Unit/MSFT_xADOrganizationalUnit.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xADOrganizationalUnit'
 

diff --git a/Tests/Unit/MSFT_xWaitForADDomain.Tests.ps1 b/Tests/Unit/MSFT_xWaitForADDomain.Tests.ps1
@@ -1,6 +1,3 @@
-[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
-param()
-
 $script:dscModuleName = 'xActiveDirectory'
 $script:dscResourceName = 'MSFT_xWaitForADDomain'