xActiveDirectory: Remove old helper functions

[johlju]

Pull Request (PR) description

• Changes to xActiveDirectory
  • Removed the helper function ThrowInvalidOperationError and ThrowInvalidArgumentError in favor of the new helper functions for localization (issue xActiveDirectory: Replace helper function ThrowInvalidOperationError #316, issue xActiveDirectory: Replace helper function ThrowInvalidArgumentError #317).
  • Cleaned up some minor style violations in the code.
  • Fixed an issue that the helper function Add-ADCommonGroupMember was
    not outputting the correct group name in a verbose message and in an
    error message.
• xADDomain
  • Updated tests and replaced Write-Error with throw
    (issue xADDomain.Tests: Replace Write-Error with throw #332).
• Changes to xADRecycleBin
  • Updated tests and remove unnecessary mocks of Write-Error.

This Pull Request (PR) fixes the following issues

• Fixes xActiveDirectory: Replace helper function ThrowInvalidOperationError #316
• Fixes xActiveDirectory: Replace helper function ThrowInvalidArgumentError #317
• Fixes xADDomain.Tests: Replace Write-Error with throw #332

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in resource directory README.md.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[johlju]

@PlagueHO mind reviewing this one? Should not take to long.

[codecov-io]

Codecov Report

Merging #418 into dev will increase coverage by <1%.
The diff coverage is 76%.

@@         Coverage Diff          @@
##            dev   #418    +/-   ##
====================================
+ Coverage    92%    92%   +<1%     
====================================
  Files        20     20            
  Lines      2553   2536    -17     
  Branches     10     10            
====================================
- Hits       2360   2347    -13     
+ Misses      183    179     -4     
  Partials     10     10

[johlju]

Reviewed 11 of 11 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions

---

CHANGELOG.md, line 29 at r1 (raw file):

- Changes to xADOrganizationalUnit
  - Catch exception when the path property specifies a non-existing path
    ([issue #408](https://github.com/PowerShell/xActiveDirectory/issues/408))

Missing full stop (.).

---

CHANGELOG.md, line 86 at r1 (raw file):

xWaitForADDomain.

Full stop is in wrong place

[johlju]

Reviewable status: 10 of 11 files reviewed, all discussions resolved (waiting on @johlju)

---

CHANGELOG.md, line 29 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Missing full stop (.).

Done

---

CHANGELOG.md, line 86 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

xWaitForADDomain.

Full stop is in wrong place

Done

[johlju]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved