Cleanup for issue #332

dsccommunity · Jul 9, 2019 · e881edb · e881edb
1 parent 6f6a95d
commit e881edb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,11 @@
     ([issue #402](https://github.com/PowerShell/xActiveDirectory/issues/402)).
   - Fixes ChangePasswordAtLogon Property to be only set to `true` at User
     Creation ([issue #414](https://github.com/PowerShell/xActiveDirectory/issues/414)).
+- xADDomain
+  - Updated tests and replaced `Write-Error` with `throw`
+    ([issue #332](https://github.com/PowerShell/xActiveDirectory/pull/332)).
+- Changes to xADRecycleBin
+  - Updated tests and remove unnecessary mocks of `Write-Error`.
 
 ## 3.0.0.0
 

diff --git a/Tests/Unit/MSFT_xADRecycleBin.Tests.ps1 b/Tests/Unit/MSFT_xADRecycleBin.Tests.ps1
@@ -111,8 +111,6 @@ try
             }
 
             Context 'When Get-AdObject throws an exception' {
-                Mock -CommandName Write-Error
-
                 It 'Should throw ADIdentityNotFoundException' {
                     Mock -CommandName Get-ADObject -MockWith {
                         throw (New-Object -TypeName Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException)
@@ -167,8 +165,6 @@ try
             }
 
             Context 'When Get-AdObject throws an exception' {
-                Mock -CommandName Write-Error
-
                 It 'Should throw ADIdentityNotFoundException' {
                     Mock -CommandName Get-ADObject -MockWith {
                         throw (New-Object -TypeName Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException)
@@ -231,8 +227,6 @@ try
             }
 
             Context 'When Get-AdForest throws an exception' {
-                Mock -CommandName Write-Error
-
                 It 'Should throw ADIdentityNotFoundException' {
                     Mock -CommandName Get-ADForest -MockWith {
                         throw (New-Object -TypeName Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException)