Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect key reference when setting site link options? #637

Closed
ixniz opened this issue Dec 10, 2020 · 1 comment · Fixed by #699
Closed

Incorrect key reference when setting site link options? #637

ixniz opened this issue Dec 10, 2020 · 1 comment · Fixed by #699
Labels
bug The issue is a bug.

Comments

@ixniz
Copy link

ixniz commented Dec 10, 2020

if ($PSBoundParameters.ContainsKey('ReplicationFrequencyInMinutes') -and

A cursory glance through the code seems to indicate that the specified line contains a reference to the wrong key.

"if ($PSBoundParameters.ContainsKey('ReplicationFrequencyInMinutes') -and"
should probably be
"if ($PSBoundParameters.ContainsKey('OptionChangeNotification') -and"

Every site link option contains the same check for the presence of the ReplicationFrequencyInMinutes key. I'm not sure if this is the intention, but it seems that if the replication frequency isn't also defined, the site link options remain the current values.

@johlju
Copy link
Member

johlju commented Dec 10, 2020

Yes, looks like you are correct.

@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Dec 10, 2020
Borgquite added a commit to Borgquite/ActiveDirectoryDsc that referenced this issue Aug 23, 2023
johlju pushed a commit that referenced this issue Aug 24, 2023
…ute not set (#699)

- ADReplicationSiteLink
  - Allow OptionChangeNotification, OptionTwoWaySync and OptionDisableCompression
    to be updated even if ReplicationFrequencyInMinutes is not set (issue #637).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug.
Projects
None yet
2 participants