Skip to content

Commit

Permalink
ADReplicationSiteLink: Fix for Options when ReplicationFrequencyInMin…
Browse files Browse the repository at this point in the history
…ute not set (#699)

- ADReplicationSiteLink
  - Allow OptionChangeNotification, OptionTwoWaySync and OptionDisableCompression
    to be updated even if ReplicationFrequencyInMinutes is not set (issue #637).
  • Loading branch information
Borgquite authored Aug 24, 2023
1 parent 94e5594 commit 131fb75
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
- ADOrganizationalUnit
- Added DomainController Parameter.

### Fixed

- ADReplicationSiteLink
- Allow OptionChangeNotification, OptionTwoWaySync and OptionDisableCompression to be updated even if
ReplicationFrequencyInMinutes is not set ([issue #637](https://github.com/dsccommunity/ActiveDirectoryDsc/issues/637)).

## [6.2.0] - 2022-05-01

### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ function Set-TargetResource
$setADReplicationSiteLinkParameters['ReplicationFrequencyInMinutes'] = $ReplicationFrequencyInMinutes
}

if ($PSBoundParameters.ContainsKey('ReplicationFrequencyInMinutes') -and
if ($PSBoundParameters.ContainsKey('OptionChangeNotification') -and
$OptionChangeNotification -ne $currentADSiteLink.OptionChangeNotification)
{
Write-Verbose -Message ($script:localizedData.SettingProperty -f
Expand All @@ -299,7 +299,7 @@ function Set-TargetResource
$desiredChangeNotification = $currentADSiteLink.OptionChangeNotification
}

if ($PSBoundParameters.ContainsKey('ReplicationFrequencyInMinutes') -and
if ($PSBoundParameters.ContainsKey('OptionTwoWaySync') -and
$OptionTwoWaySync -ne $currentADSiteLink.OptionTwoWaySync)
{
Write-Verbose -Message ($script:localizedData.SettingProperty -f
Expand All @@ -311,7 +311,7 @@ function Set-TargetResource
$desiredTwoWaySync = $currentADSiteLink.OptionTwoWaySync
}

if ($PSBoundParameters.ContainsKey('ReplicationFrequencyInMinutes') -and
if ($PSBoundParameters.ContainsKey('OptionDisableCompression') -and
$OptionDisableCompression -ne $currentADSiteLink.OptionDisableCompression)
{
Write-Verbose -Message ($script:localizedData.SettingProperty -f
Expand Down

0 comments on commit 131fb75

Please sign in to comment.