Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: Integration tests are comparing the wrong value for Test-DscConfiguration #434

Closed
johlju opened this issue Jul 15, 2019 · 0 comments · Fixed by #459
Closed

ActiveDirectoryDsc: Integration tests are comparing the wrong value for Test-DscConfiguration #434

johlju opened this issue Jul 15, 2019 · 0 comments · Fixed by #459
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Jul 15, 2019

All integration tests was wrongly changed to Test-DscConfiguration -Verbose | Should -BeTrue in one of the last merges. This must be Test-DscConfiguration -Verbose | Should -Be 'True' since Test-DscConfiguration does not return a boolean, but a string of either 'True' or 'False'

/cc @PlagueHO
@johlju johlju added good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Jul 15, 2019
@johlju johlju changed the title xActiveDirectory: Integration tests are comparing the wrong value for Test-DscConfiguration ActiveDirectoryDsc: Integration tests are comparing the wrong value for Test-DscConfiguration Jul 28, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 2, 2019
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Aug 2, 2019
@johlju
Changes to ActiveDirectoryDsc
3f58131 
- Integration tests are now correctly evaluates the value from `Test-DscConfiguration` (issue dsccommunity#434).
@johlju johlju mentioned this issue Aug 2, 2019
Merged
9 tasks
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Aug 3, 2019
@johlju
Changes to ActiveDirectoryDsc
ffad953 
- Integration tests are now correctly evaluates the value from `Test-DscConfiguration` (issue dsccommunity#434).
johlju added a commit that referenced this issue Aug 3, 2019
@johlju
Changes to ActiveDirectoryDsc (#459)
3a4b75f 
- Changes to ActiveDirectoryDsc
  - Integration tests are now correctly evaluates the value from `Test-DscConfiguration` (issue #434).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
1 participant
@johlju