Changes to ActiveDirectoryDsc (#459)

- Changes to ActiveDirectoryDsc - Integration tests are now correctly evaluates the value from `Test-DscConfiguration` (issue #434).
dsccommunity · Aug 3, 2019 · 3a4b75f · 3a4b75f
1 parent 50197b4
commit 3a4b75f
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -57,6 +57,8 @@
     Azure Automation ([issue #416](https://github.com/PowerShell/ActiveDirectoryDsc/issues/416)).
   - Fix examples that had duplicate guid that would have prevented them
     to be published.
+  - Integration tests are now correctly evaluates the value from `Test-DscConfiguration`
+    ([issue #434](https://github.com/PowerShell/ActiveDirectoryDsc/issues/434)).
 - Changes to ADManagedServiceAccount
   - Added a requirement to README stating "Group Managed Service Accounts
     need at least one Windows Server 2012 Domain Controller"

diff --git a/Tests/Integration/MSFT_ADComputer.Integration.Tests.ps1 b/Tests/Integration/MSFT_ADComputer.Integration.Tests.ps1
@@ -93,7 +93,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -140,7 +140,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -187,7 +187,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -234,7 +234,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -285,7 +285,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -349,7 +349,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -380,7 +380,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
     }

diff --git a/Tests/Integration/MSFT_ADDomainTrust.Integration.Tests.ps1 b/Tests/Integration/MSFT_ADDomainTrust.Integration.Tests.ps1
@@ -81,7 +81,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -132,7 +132,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -183,7 +183,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -234,7 +234,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -285,7 +285,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -336,7 +336,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
     }

diff --git a/Tests/Integration/MSFT_ADUser.Integration.Tests.ps1 b/Tests/Integration/MSFT_ADUser.Integration.Tests.ps1
@@ -80,7 +80,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
 
@@ -130,7 +130,7 @@ try
             }
 
             It 'Should return $true when Test-DscConfiguration is run' {
-                Test-DscConfiguration -Verbose | Should -BeTrue
+                Test-DscConfiguration -Verbose | Should -Be 'True'
             }
         }
     }