Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All modules should be loaded when performing post-updates #3311

Merged
merged 17 commits into from
Jan 19, 2018

Conversation

pfrenssen
Copy link
Member

@pfrenssen pfrenssen commented Jan 16, 2018

Fixes #3308.

Postponed on #3310.

@pfrenssen
Copy link
Member Author

The test case replicates the error that was reported by @claudiu-cristea in #3308:

 [notice] Update started: woot_post_update_render
 [error]  The theme implementations may not be rendered until all modules are loaded. 
 [error]  Update failed: woot_post_update_render 

@pfrenssen pfrenssen changed the title [WIP] All modules should be loaded when performing post-updates All modules should be loaded when performing post-updates Jan 18, 2018
@pfrenssen
Copy link
Member Author

OK this is ready for a look. Note that it is blocked on #3310.

@claudiu-cristea
Copy link
Member

claudiu-cristea commented Jan 18, 2018

I tested this on a complex project with a lot of updates and post-updates and is fixing the bug. We discovered this bug in the same project with the same list of updates/post-updates. I see there's also a test that proves the bug and the fix. @weitzman, @greg-1-anderson, this could be committed but not before #3310.

@weitzman weitzman merged commit 9e0ec0a into drush-ops:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants