Post-update logging #3310
Merged
Post-update logging #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into post-update-logging
pfrenssen
force-pushed
the
post-update-logging
branch
from
c5faa7e to
0511043
Compare
|
The tests show that practically no useful output is being logged during the execution of the post-updates. This can be fixed by moving the post-update code into a batch operation inside Drush, similar to how it was done for |
This was referenced Jan 16, 2018
|
Discussed with @pfrenssen and I will review this PR tomorrow morning so it can be quickly ready for the 9 stable release. |
| * @param array $context | ||
| * The batch context. | ||
| */ | ||
| public function updateDoOnePostUpdate($function, &$context) |
There was a problem hiding this comment.
It seems that post updates have their own way of logging. Sad that we can not reuse the Drupal code.
|
Thank you. The exception message is now logged. Review done. @weitzman, this can be merged. |
This was referenced Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3308
This is postponed on #3302 and #3303.