Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drush dependency phpdocumentor/reflection-docblock to 2.x #2369

Closed
wants to merge 3 commits into from
Closed

Update drush dependency phpdocumentor/reflection-docblock to 2.x #2369

wants to merge 3 commits into from

Conversation

JTubex
Copy link
Contributor

@JTubex JTubex commented Sep 29, 2016

Drush is currently broken when phpdocumentor/reflection-docblock version 3 is used as seen in #2365

@greg-1-anderson
Copy link
Member

It would be nice to have a test that fails (would fail) with 3.x, but passes with this PR.

@JTubex
Copy link
Contributor Author

JTubex commented Sep 29, 2016

I'm unfamiliar with drush best-practices, but this test did the trick for me.

@greg-1-anderson
Copy link
Member

While I appreciate your efforts, I don't think that a test of composer update is what we need here. The general idea is to exercise some Drupal code that calls phpdocumentor, so that if in the future the version Drush pulls in becomes incompatible with Drupal's version (e.g. if they upgrade to version 3.x), then the test should fail.

We could potentially just merge here if no one has time to do that, but it would be good to have.

@weitzman
Copy link
Member

Thanks. Decided to commit this to 8.x and master, without the test. Appreciate your efforts.

@dsteplight
Copy link

I manually removed the folder from my vendors directory. That solved the problem for me.

gaelg pushed a commit to gaelg/drush that referenced this pull request Nov 7, 2016
@podarok podarok mentioned this pull request Jan 27, 2017
mikeker pushed a commit to mikeker/drush that referenced this pull request Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants