Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen phpdocumentor constraint #2877

Closed
wants to merge 1 commit into from

Conversation

greg-1-anderson
Copy link
Member

@greg-1-anderson greg-1-anderson changed the base branch from master to 8.x August 14, 2017 19:13
@greg-1-anderson
Copy link
Member Author

This PR would break the global Drush, I think; I'm not convinced we should merge it. See: #2369

@greg-1-anderson
Copy link
Member Author

I am +1 on removing this constraint from the master branch, but -1 on merging this PR into 8.x. Weakening this constraint is better for Composer-managed Drupal + Drush installations, but leaving it as it is is better for global Drush issues.

The global Drush + dep hell problem is being worked on at #2787 for 8.x and #2843 for the master branch.

Note that Drupal still pins phpdocumentor to version 2.0.4. Folks generally should not update a Drupal site with an unbounded composer update. See https://github.com/webflo/drupal-core-strict for a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant